You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org> on 2018/02/07 19:37:53 UTC
[Impala-ASF-CR] Revert "IMPALA-6215: Removes race when using LibCache."
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9244
Change subject: Revert "IMPALA-6215: Removes race when using LibCache."
......................................................................
Revert "IMPALA-6215: Removes race when using LibCache."
This reverts commit 4aafa5e9ba9fe22d2dbc7764a796b3cd04136cc0.
See IMPALA-6488 for an example of a crash that this revert is
trying to avoid.
Change-Id: I2e0a22d38f15fb3e34f08633ab0fc7c87c92d40f
---
M be/src/codegen/llvm-codegen.cc
M be/src/exec/external-data-source-executor.cc
M be/src/exprs/hive-udf-call.cc
M be/src/exprs/hive-udf-call.h
M be/src/runtime/lib-cache.cc
M be/src/runtime/lib-cache.h
M be/src/service/fe-support.cc
M tests/query_test/test_udfs.py
8 files changed, 53 insertions(+), 172 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/9244/1
--
To view, visit http://gerrit.cloudera.org:8080/9244
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e0a22d38f15fb3e34f08633ab0fc7c87c92d40f
Gerrit-Change-Number: 9244
Gerrit-PatchSet: 1
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] Revert "IMPALA-6215: Removes race when using LibCache."
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9244 )
Change subject: Revert "IMPALA-6215: Removes race when using LibCache."
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9244
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e0a22d38f15fb3e34f08633ab0fc7c87c92d40f
Gerrit-Change-Number: 9244
Gerrit-PatchSet: 1
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Feb 2018 20:54:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-6215: Removes race when using LibCache."
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9244 )
Change subject: Revert "IMPALA-6215: Removes race when using LibCache."
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9244
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e0a22d38f15fb3e34f08633ab0fc7c87c92d40f
Gerrit-Change-Number: 9244
Gerrit-PatchSet: 1
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Feb 2018 19:43:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-6215: Removes race when using LibCache."
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9244 )
Change subject: Revert "IMPALA-6215: Removes race when using LibCache."
......................................................................
Revert "IMPALA-6215: Removes race when using LibCache."
This reverts commit 4aafa5e9ba9fe22d2dbc7764a796b3cd04136cc0.
See IMPALA-6488 for an example of a crash that this revert is
trying to avoid.
Change-Id: I2e0a22d38f15fb3e34f08633ab0fc7c87c92d40f
Reviewed-on: http://gerrit.cloudera.org:8080/9244
Reviewed-by: Alex Behm <al...@cloudera.com>
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Reviewed-by: Vuk Ercegovac <ve...@cloudera.com>
Tested-by: Thomas Tauber-Marshall <tm...@cloudera.com>
---
M be/src/codegen/llvm-codegen.cc
M be/src/exec/external-data-source-executor.cc
M be/src/exprs/hive-udf-call.cc
M be/src/exprs/hive-udf-call.h
M be/src/runtime/lib-cache.cc
M be/src/runtime/lib-cache.h
M be/src/service/fe-support.cc
M tests/query_test/test_udfs.py
8 files changed, 53 insertions(+), 172 deletions(-)
Approvals:
Alex Behm: Looks good to me, approved
Tim Armstrong: Looks good to me, approved
Vuk Ercegovac: Looks good to me, but someone else must approve
Thomas Tauber-Marshall: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9244
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e0a22d38f15fb3e34f08633ab0fc7c87c92d40f
Gerrit-Change-Number: 9244
Gerrit-PatchSet: 2
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] Revert "IMPALA-6215: Removes race when using LibCache."
Posted by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org>.
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9244 )
Change subject: Revert "IMPALA-6215: Removes race when using LibCache."
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/9244
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e0a22d38f15fb3e34f08633ab0fc7c87c92d40f
Gerrit-Change-Number: 9244
Gerrit-PatchSet: 1
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Feb 2018 20:02:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-6215: Removes race when using LibCache."
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9244 )
Change subject: Revert "IMPALA-6215: Removes race when using LibCache."
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9244
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e0a22d38f15fb3e34f08633ab0fc7c87c92d40f
Gerrit-Change-Number: 9244
Gerrit-PatchSet: 1
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Feb 2018 19:43:07 +0000
Gerrit-HasComments: No