[GitHub] [pinot] amrishlal commented on a diff in pull request #9078: Throw an exception when MV columns are the first order-by expression in selection order-by queries

[GitBox <gi...@apache.org>]

amrishlal commented on code in PR #9078:
URL: https://github.com/apache/pinot/pull/9078#discussion_r927113146


##########
pinot-core/src/main/java/org/apache/pinot/core/plan/maker/InstancePlanMakerImplV2.java:
##########
@@ -250,13 +250,33 @@ public PlanNode makeSegmentPlanNode(IndexSegment indexSegment, QueryContext quer
         return new AggregationPlanNode(indexSegment, queryContext);
       }
     } else if (QueryContextUtils.isSelectionQuery(queryContext)) {
+      validateSelectionOrderByExpressions(indexSegment, queryContext);

Review Comment:
   Is this the earliest stage that this check can be done? We should try to do such semantic checks as soon as possible (during or right after parsing) so that the query can be failed as quickly as possible without consuming any extra resources. There are a bunch of checks in BrokerRequestHandler, so I am wondering if this check can be done there instead of in server side plan generation?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org