You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2016/12/23 15:52:17 UTC

[GitHub] zeppelin pull request #1802: [MINOR] Validate before setting focus to paragr...

GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/1802

    [MINOR] Validate before setting focus to paragraphs

    ### What is this PR for?
    
    Fixed fragile code in notebook.controller.js. This code causes loading errors as u can see the screenshot above. Especially in different loading system (e.g es6 import, require, webpack)
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    
    Nothing
    
    ### What is the Jira issue?
    
    MINOR issue
    
    ### How should this be tested?
    Outline the steps to test the PR here.
    
    ### Screenshots (if appropriate)
    
    <img width="1440" alt="focus" src="https://cloud.githubusercontent.com/assets/4968473/21457488/fe1de3e0-c972-11e6-87f9-309c576e4421.png">
    
    
    ### Questions:
    * Does the licenses files need update?
    * Is there breaking changes for older versions?
    * Does this needs documentation?


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin fix/validate-before-setting-focus

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1802.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1802
    
----
commit 720e891dd1706ad897aa8944e8a1ad08482f1abb
Author: 1ambda <1a...@gmail.com>
Date:   2016-12-23T15:48:22Z

    fix: Fragile code in notebook.controller.js

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1802: [MINOR] fix: Validate before setting focus to paragrap...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1802
  
    LGTM and merge to master if there're no more comments


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1802: [MINOR] fix: Validate before setting focus to p...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1802


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---