You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by gr...@apache.org on 2018/08/27 19:32:13 UTC
[2/3] kudu git commit: build-and-test: export EXTRA_GRADLE_FLAGS
build-and-test: export EXTRA_GRADLE_FLAGS
build-and-test.sh generates a list of flags with which to configure
gradle. Unless these configurations are `export`ed, they won't be
visible in other processes, e.g. when running dist_test.py.
Notably, this would result in dist_test.py calling gradlew with Scala
formatting (which breaks some builds), even though it was expected to be
disabled.
I didn't test the fix explicitly, but I ran the following to verify the
fix should work:
$ echo "import os
print os.getenv('TEST_VAR', '')" > test.py
$ TEST_VAR=3
$ python test.py
$ export TEST_VAR=5
$ python test.py
5
Change-Id: I84ffdab0d2c78419d0edc65e6c03d79b510676fb
Reviewed-on: http://gerrit.cloudera.org:8080/11329
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Kudu Jenkins
Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/1308db96
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/1308db96
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/1308db96
Branch: refs/heads/master
Commit: 1308db96877a5a2d73510486d973d2093a17a936
Parents: 30abac0
Author: Andrew Wong <aw...@cloudera.com>
Authored: Sat Aug 25 13:34:23 2018 -0700
Committer: Andrew Wong <aw...@cloudera.com>
Committed: Sat Aug 25 21:13:41 2018 +0000
----------------------------------------------------------------------
build-support/jenkins/build-and-test.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kudu/blob/1308db96/build-support/jenkins/build-and-test.sh
----------------------------------------------------------------------
diff --git a/build-support/jenkins/build-and-test.sh b/build-support/jenkins/build-and-test.sh
index 352fd17..d1a3e42 100755
--- a/build-support/jenkins/build-and-test.sh
+++ b/build-support/jenkins/build-and-test.sh
@@ -395,7 +395,7 @@ if [ "$BUILD_JAVA" == "1" ]; then
# Run the full Gradle build.
if [ "$BUILD_GRADLE" == "1" ]; then
- EXTRA_GRADLE_FLAGS="--console=plain"
+ export EXTRA_GRADLE_FLAGS="--console=plain"
EXTRA_GRADLE_FLAGS="$EXTRA_GRADLE_FLAGS --no-daemon"
EXTRA_GRADLE_FLAGS="$EXTRA_GRADLE_FLAGS --continue"
EXTRA_GRADLE_FLAGS="$EXTRA_GRADLE_FLAGS -DrerunFailingTestsCount=3"