[GitHub] [tinkerpop] WiredUK edited a comment on issue #1172: Handle closed connections gracefully instead of bubbling up exceptions

[GitBox <gi...@apache.org>]

WiredUK edited a comment on issue #1172: Handle closed connections gracefully instead of bubbling up exceptions
URL: https://github.com/apache/tinkerpop/pull/1172#issuecomment-518215098
 
 
   > Is the `NullReferenceException` you're getting the same as described in [TINKERPOP-2192](https://issues.apache.org/jira/browse/TINKERPOP-2192)?
   
   Hmm, it could be, it's definitely happening around the same part of the code. But if it is, your deduction about the cause is slightly off I think. Note that the NREs that I am seeing are not exposed outside the Gremlin.Net library, they just get logged in the output window. Everything works fine, it's just slowing things down.
   
   > If not, can you please provide a stack trace?
   
   Sure, stack trace is:
   
   ```
   at Gremlin.Net.Driver.Connection.TryParseResponseMessage(ResponseMessage`1 receivedMsg) in C:\path\Gremlin.Net\Driver\Connection.cs:line 136
   at Gremlin.Net.Driver.Connection.Parse(Byte[] received) in C:\path\Gremlin.Net\Driver\Connection.cs:line 123
   ```
   
   The error happens because `Parse` is receiving an empty byte array, which in turn makes `_messageSerializer.DeserializeMessage<ResponseMessage<JToken>>(received)` return `null`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services