You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by enixon <gi...@git.apache.org> on 2018/03/01 20:30:42 UTC
[GitHub] zookeeper pull request #478: ZOOKEEPER-2988: NPE triggered if server receive...
GitHub user enixon opened a pull request:
https://github.com/apache/zookeeper/pull/478
ZOOKEEPER-2988: NPE triggered if server receives a vote for a server …
…id not in their voting view
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/enixon/zookeeper ZOOKEEPER-2988-3.4
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/478.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #478
----
commit 6fc857a1cfe97a46a4f453613b95f9682adcce96
Author: Brian Nixon <ni...@...>
Date: 2018-03-01T19:19:51Z
ZOOKEEPER-2988: NPE triggered if server receives a vote for a server id not in their voting view
----
---
[GitHub] zookeeper issue #478: ZOOKEEPER-2988: NPE triggered if server receives a vot...
Posted by enixon <gi...@git.apache.org>.
Github user enixon commented on the issue:
https://github.com/apache/zookeeper/pull/478
The only failure report out of Jenkins is "Test org.apache.zookeeper.test.FollowerResyncConcurrencyTest FAILED (crashed)". I'm unable to repro any issue with that test on my branch locally, is there a good way to re-run the test?
---
[GitHub] zookeeper pull request #478: ZOOKEEPER-2988: NPE triggered if server receive...
Posted by enixon <gi...@git.apache.org>.
Github user enixon closed the pull request at:
https://github.com/apache/zookeeper/pull/478
---
[GitHub] zookeeper issue #478: ZOOKEEPER-2988: NPE triggered if server receives a vot...
Posted by enixon <gi...@git.apache.org>.
Github user enixon commented on the issue:
https://github.com/apache/zookeeper/pull/478
Thanks, @hanm !
---
[GitHub] zookeeper issue #478: ZOOKEEPER-2988: NPE triggered if server receives a vot...
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/478
@enixon "FollowerResyncConcurrencyTest " is a known flaky test (and the error in this case is infrastructure issues - the JVM abnormally exit). I tested your patch using a Jenkins job and everything looks good. Committed, please close this pull request.
>> is there a good way to re-run the test
P.S. to kick off the pre-commit build bot, you can close the pull request and reopen it.
---