[GitHub] [arrow-nanoarrow] paleolimbot commented on pull request #205: feat(extensions/nanoarrow_device): Draft DeviceArray interface

["paleolimbot (via GitHub)" <gi...@apache.org>]

paleolimbot commented on PR #205:
URL: https://github.com/apache/arrow-nanoarrow/pull/205#issuecomment-1603076375

   Ok! There are definitely some holes in this implementation (notably around properly synchronizing memory copies). I'd propose that this PR get merged (and clearly marked as under development/experimental in the README) with some related changes.
   
   - Switch to using the driver library: https://github.com/apache/arrow-nanoarrow/issues/246
   - Properly order copy operations when copying to/from device: https://github.com/apache/arrow-nanoarrow/issues/245
   - Expand test coverage to more than just string arrays: https://github.com/apache/arrow-nanoarrow/issues/247
   
   I think it's still an open question as to whether or not this particular extension will be used/will be useful...if there is no interest in using it before the next release it can always be excluded from the source release (like the Python bindings currently are) or moved back to a PR state.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org