[jira] [Commented] (BEAM-1306) Support additional configuration in BigQueryServices.insertAll()

["Beam JIRA Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189530#comment-17189530 ] 

Beam JIRA Bot commented on BEAM-1306:
-------------------------------------

This issue was marked "stale-P2" and has not received a public comment in 14 days. It is now automatically moved to P3. If you are still affected by it, you can comment and move it back to P2.

> Support additional configuration in BigQueryServices.insertAll()
> ----------------------------------------------------------------
>
>                 Key: BEAM-1306
>                 URL: https://issues.apache.org/jira/browse/BEAM-1306
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-gcp
>            Reporter: Pei He
>            Priority: P3
>
> ignoreUnknownValues is requested in https://issues.apache.org/jira/browse/BEAM-1267
> There are additional configurations that could be useful.
> TableDataInsertAllRequest content = new TableDataInsertAllRequest();
> content.setSkipInvalidRows();
> content.setTemplateSuffix();
> content.setKind();
>             
> I think we can improve the BigQueryServices interface by define it as:
> void insertAll(TableReference ref, Collection<TableDataInsertAllRequest> request);
> and, provided a static method to prepare requests:
> List<TableDataInsertAllRequest> makeInsertBatches(List<TableRow> rowList, @Nullable List<String> insertIdList);
> Then, client can set additional config in the returned list.
> Reference:
> GcsUtil.java has similar implementation in makeCopyBatches() and executeBatches().
> https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/util/GcsUtil.java#L550



--
This message was sent by Atlassian Jira
(v8.3.4#803005)