You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2018/02/08 15:41:16 UTC
Review Request 65570: WIP: Attached/detached volume directory for
task which has volume specified.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65570/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
Attached/detached volume directory for task which has volume specified.
Diffs
-----
src/slave/slave.cpp f98f37321872d090176b7cc50873fc3c627773f5
Diff: https://reviews.apache.org/r/65570/diff/1/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 65570: Attached/detached volume directory for task
which has volume specified.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65570/#review197231
-----------------------------------------------------------
PASS: Mesos patch 65570 was successfully built and tested.
Reviews applied: `['65570']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65570
- Mesos Reviewbot Windows
On Feb. 10, 2018, 2:59 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65570/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2018, 2:59 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-8565
> https://issues.apache.org/jira/browse/MESOS-8565
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Attached/detached volume directory for task which has volume specified.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 30151c4886e12e9183a971b86b854e28a8ca1b39
> src/slave/slave.cpp f98f37321872d090176b7cc50873fc3c627773f5
>
>
> Diff: https://reviews.apache.org/r/65570/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 65570: Attached/detached volume directory for task
which has volume specified.
Posted by Qian Zhang <zh...@gmail.com>.
> On Feb. 13, 2018, 9:38 a.m., Vinod Kone wrote:
> > Can you add tests for this in a subsequent review please?
Yes, here it is: https://reviews.apache.org/r/65630/
> On Feb. 13, 2018, 9:38 a.m., Vinod Kone wrote:
> > src/slave/slave.cpp
> > Lines 1109-1111 (patched)
> > <https://reviews.apache.org/r/65570/diff/2/?file=1955934#file1955934line1109>
> >
> > I don't think we need this check. We want to show non PV directories too in the UI.
That was actually my original solution, but after more consideration and testing, I found we still need this check. The reason is, if we do not have this check, that means we will do attach as long as the task's ContainerInfo has a `SANDBOX_PATH` volume with type `PARENT`, but such attach will fail (see below) because the executor's volume directory is not created yet at the moment when `attachTaskVolumeDirectory` is called, it will actually be created by the `volume/sandbox_path` isolator when launching the nested container.
```
E0212 22:23:08.905462 10350 slave.cpp:1009] Failed to attach '/home/qzhang/opt/mesos/slaves/54de35d5-250f-4bf9-9444-3633c5e66e7d-S0/frameworks/54de35d5-250f-4bf9-9444-3633c5e66e7d-0000/executors/default-executor/runs/0ea4dc53-e543-42c4-8bb5-c5b667eee4c0/foo' to virtual path '/home/qzhang/opt/mesos/slaves/54de35d5-250f-4bf9-9444-3633c5e66e7d-S0/frameworks/54de35d5-250f-4bf9-9444-3633c5e66e7d-0000/executors/default-executor/runs/0ea4dc53-e543-42c4-8bb5-c5b667eee4c0/tasks/test/xxx': Failed to get realpath of '/home/qzhang/opt/mesos/slaves/54de35d5-250f-4bf9-9444-3633c5e66e7d-S0/frameworks/54de35d5-250f-4bf9-9444-3633c5e66e7d-0000/executors/default-executor/runs/0ea4dc53-e543-42c4-8bb5-c5b667eee4c0/foo': No such file or directory
```
So I think we still need this check which will ensure the executor's volume directory exists before we do the attach, the executor's volume directory will actually be created by the `filesystem/linux` isolator when launching the executor.
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65570/#review197359
-----------------------------------------------------------
On Feb. 13, 2018, 5:20 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65570/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2018, 5:20 p.m.)
>
>
> Review request for mesos, Gilbert Song and Vinod Kone.
>
>
> Bugs: MESOS-8565
> https://issues.apache.org/jira/browse/MESOS-8565
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Attached/detached volume directory for task which has volume specified.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 30151c4886e12e9183a971b86b854e28a8ca1b39
> src/slave/slave.cpp f98f37321872d090176b7cc50873fc3c627773f5
>
>
> Diff: https://reviews.apache.org/r/65570/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 65570: Attached/detached volume directory for task
which has volume specified.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65570/#review197359
-----------------------------------------------------------
Can you add tests for this in a subsequent review please?
src/slave/slave.hpp
Line 434 (original), 442 (patched)
<https://reviews.apache.org/r/65570/#comment277482>
s/at it to make it can be/to it so that it can be/
src/slave/slave.hpp
Line 435 (original), 443 (patched)
<https://reviews.apache.org/r/65570/#comment277483>
s/, so/. So/
src/slave/slave.cpp
Line 1043 (original), 1044 (patched)
<https://reviews.apache.org/r/65570/#comment277493>
can you fix the naming to be consistent with below comments?
src/slave/slave.cpp
Lines 1075 (patched)
<https://reviews.apache.org/r/65570/#comment277484>
`containerInfo`
src/slave/slave.cpp
Lines 1078-1087 (patched)
<https://reviews.apache.org/r/65570/#comment277495>
kill this. see below.
src/slave/slave.cpp
Lines 1089-1091 (patched)
<https://reviews.apache.org/r/65570/#comment277497>
kill this.
src/slave/slave.cpp
Lines 1109-1111 (patched)
<https://reviews.apache.org/r/65570/#comment277488>
I don't think we need this check. We want to show non PV directories too in the UI.
src/slave/slave.cpp
Lines 1113 (patched)
<https://reviews.apache.org/r/65570/#comment277491>
executorRunPath
src/slave/slave.cpp
Lines 1120 (patched)
<https://reviews.apache.org/r/65570/#comment277490>
s/executorVolumePath/executorDirectoryPath/
src/slave/slave.cpp
Lines 1131 (patched)
<https://reviews.apache.org/r/65570/#comment277492>
taskDirectoryPath
src/slave/slave.cpp
Lines 1157-1167 (patched)
<https://reviews.apache.org/r/65570/#comment277494>
kill this.
src/slave/slave.cpp
Lines 1196-1198 (patched)
<https://reviews.apache.org/r/65570/#comment277496>
kill this.
src/slave/slave.cpp
Lines 1219-1221 (patched)
<https://reviews.apache.org/r/65570/#comment277498>
kill this.
src/slave/slave.cpp
Lines 1231 (patched)
<https://reviews.apache.org/r/65570/#comment277499>
taskDirectoryPath
- Vinod Kone
On Feb. 10, 2018, 2:59 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65570/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2018, 2:59 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-8565
> https://issues.apache.org/jira/browse/MESOS-8565
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Attached/detached volume directory for task which has volume specified.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 30151c4886e12e9183a971b86b854e28a8ca1b39
> src/slave/slave.cpp f98f37321872d090176b7cc50873fc3c627773f5
>
>
> Diff: https://reviews.apache.org/r/65570/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 65570: Attached/detached volume directory for task
which has volume specified.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65570/#review197232
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65570]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 10, 2018, 2:59 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65570/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2018, 2:59 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-8565
> https://issues.apache.org/jira/browse/MESOS-8565
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Attached/detached volume directory for task which has volume specified.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 30151c4886e12e9183a971b86b854e28a8ca1b39
> src/slave/slave.cpp f98f37321872d090176b7cc50873fc3c627773f5
>
>
> Diff: https://reviews.apache.org/r/65570/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 65570: Attached/detached volume directory for task
which has volume specified.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65570/#review197387
-----------------------------------------------------------
PASS: Mesos patch 65570 was successfully built and tested.
Reviews applied: `['65570']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65570
- Mesos Reviewbot Windows
On Feb. 13, 2018, 2:47 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65570/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2018, 2:47 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-8565
> https://issues.apache.org/jira/browse/MESOS-8565
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Attached/detached volume directory for task which has volume specified.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 30151c4886e12e9183a971b86b854e28a8ca1b39
> src/slave/slave.cpp f98f37321872d090176b7cc50873fc3c627773f5
>
>
> Diff: https://reviews.apache.org/r/65570/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 65570: Attached/detached volume directory for task
which has volume specified.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65570/
-----------------------------------------------------------
(Updated Feb. 13, 2018, 2:47 p.m.)
Review request for mesos and Gilbert Song.
Changes
-------
Addressed review comments.
Bugs: MESOS-8565
https://issues.apache.org/jira/browse/MESOS-8565
Repository: mesos
Description
-------
Attached/detached volume directory for task which has volume specified.
Diffs (updated)
-----
src/slave/slave.hpp 30151c4886e12e9183a971b86b854e28a8ca1b39
src/slave/slave.cpp f98f37321872d090176b7cc50873fc3c627773f5
Diff: https://reviews.apache.org/r/65570/diff/3/
Changes: https://reviews.apache.org/r/65570/diff/2-3/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 65570: Attached/detached volume directory for task
which has volume specified.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65570/
-----------------------------------------------------------
(Updated Feb. 10, 2018, 10:59 p.m.)
Review request for mesos and Gilbert Song.
Changes
-------
Add some comments in the code.
Summary (updated)
-----------------
Attached/detached volume directory for task which has volume specified.
Bugs: MESOS-8565
https://issues.apache.org/jira/browse/MESOS-8565
Repository: mesos
Description
-------
Attached/detached volume directory for task which has volume specified.
Diffs (updated)
-----
src/slave/slave.hpp 30151c4886e12e9183a971b86b854e28a8ca1b39
src/slave/slave.cpp f98f37321872d090176b7cc50873fc3c627773f5
Diff: https://reviews.apache.org/r/65570/diff/2/
Changes: https://reviews.apache.org/r/65570/diff/1-2/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 65570: WIP: Attached/detached volume directory for
task which has volume specified.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65570/
-----------------------------------------------------------
(Updated Feb. 10, 2018, 9:01 a.m.)
Review request for mesos and Gilbert Song.
Bugs: MESOS-8565
https://issues.apache.org/jira/browse/MESOS-8565
Repository: mesos
Description
-------
Attached/detached volume directory for task which has volume specified.
Diffs
-----
src/slave/slave.cpp f98f37321872d090176b7cc50873fc3c627773f5
Diff: https://reviews.apache.org/r/65570/diff/1/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 65570: WIP: Attached/detached volume directory for
task which has volume specified.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65570/#review197093
-----------------------------------------------------------
PASS: Mesos patch 65570 was successfully built and tested.
Reviews applied: `['65570']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65570
- Mesos Reviewbot Windows
On Feb. 8, 2018, 3:41 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65570/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2018, 3:41 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-8279
> https://issues.apache.org/jira/browse/MESOS-8279
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Attached/detached volume directory for task which has volume specified.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp f98f37321872d090176b7cc50873fc3c627773f5
>
>
> Diff: https://reviews.apache.org/r/65570/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 65570: WIP: Attached/detached volume directory for
task which has volume specified.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65570/
-----------------------------------------------------------
(Updated Feb. 8, 2018, 11:41 p.m.)
Review request for mesos.
Bugs: MESOS-8279
https://issues.apache.org/jira/browse/MESOS-8279
Repository: mesos
Description
-------
Attached/detached volume directory for task which has volume specified.
Diffs
-----
src/slave/slave.cpp f98f37321872d090176b7cc50873fc3c627773f5
Diff: https://reviews.apache.org/r/65570/diff/1/
Testing
-------
Thanks,
Qian Zhang