[GitHub] [incubator-pinot] kishoreg commented on pull request #6039: WIP: ServiceManager ADD_TABLE role

[GitBox <gi...@apache.org>]

kishoreg commented on pull request #6039:
URL: https://github.com/apache/incubator-pinot/pull/6039#issuecomment-706821231


   High-level comment, AddTable is a very specific role and seems to solve one specific problem. Its probably better to either enhance the minion role to perform a task or add a new role (pinot-admin) and add table can be passed as a task. This will allow us to add more setup tasks without having to add a new role for each task. 
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org