You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@magpie.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2026/09/15 16:28:07 UTC
[PR] ci: bump allowlist-check pin to pick up $/ self-repository support [magpie]
potiuk opened a new pull request, #1235:
URL: https://github.com/apache/magpie/pull/1235
The `allowlist-check` pin is meant to track `infrastructure-actions` main, but it had drifted behind it.
`69afc125` predates `df54e48` (apache/infrastructure-actions#1254), the commit where `SKIPPED_PREFIXES` gained `"$/"` alongside `"./"` and `"docker://"`:
```python
# allowlist-check/check_asf_allowlist.py
SKIPPED_PREFIXES = ("./", "docker://", "$/")
```
Without that entry the four `uses: $/.github/workflows/*.yml` refs in `bump-dev-version.yml` are not recognised as self-repository refs, so they fall through to the org allowlist lookup, miss, and are reported as unapproved:
```
Found 4 action ref(s) not on the ASF allowlist:
$/.github/workflows/pre-commit.yml is not on the ASF allowlist
$/.github/workflows/rat.yml is not on the ASF allowlist
$/.github/workflows/tests.yml is not on the ASF allowlist
$/.github/workflows/zizmor.yml is not on the ASF allowlist
```
It also renders nonsense remediation commands, since the `$` is carried into branch names:
```
git checkout -b 'allowlist-add-$-.github-workflows-rat.yml'
```
`6a1ab42cdbe0eb31cf051a6b702947167fea89fe` is current `infrastructure-actions` main; `SKIPPED_PREFIXES` there includes `"$/"`. Anything at or after `df54e48` would do, but the comment on this line says the pin tracks main, so it goes to main.
Seen on https://github.com/apache/magpie/actions/runs/34994454470/job/104467066418 (#1234), which should go green once this lands and #1234 picks it up.
No change to what the check enforces - `$/` refs resolve to this repository at the commit being run, so they were never subject to the org allowlist in the first place.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: bump allowlist-check pin to pick up $/ self-repository support [magpie]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #1235:
URL: https://github.com/apache/magpie/pull/1235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org