You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by aljoscha <gi...@git.apache.org> on 2016/02/19 20:03:40 UTC
[GitHub] flink pull request: [FLINK-3439] Remove final Long.MAX_VALUE Water...
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/1677
[FLINK-3439] Remove final Long.MAX_VALUE Watermark in StreamSource
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink watermark-remove-final-max
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1677.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1677
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3439] Remove final Long.MAX_VALUE Water...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1677#discussion_r53515651
--- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/timestamp/TimestampITCase.java ---
@@ -346,9 +339,6 @@ public long checkAndGetNextWatermark(Integer element, long extractedTimestamp) {
Assert.fail("Wrong watermark.");
}
}
- if (!CustomOperator.finalWatermarks[0].get(NUM_ELEMENTS).equals(new Watermark(Long.MAX_VALUE))) {
--- End diff --
Check like above
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3439] Remove final Long.MAX_VALUE Water...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/1677
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3439] Remove final Long.MAX_VALUE Water...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1677#issuecomment-186605514
I added the checks, will merge later once travis runs through.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3439] Remove final Long.MAX_VALUE Water...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1677#discussion_r53515589
--- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/timestamp/TimestampITCase.java ---
@@ -157,13 +157,6 @@ public void testWatermarkPropagation() throws Exception {
Assert.fail("Wrong watermark.");
}
}
- if (!CustomOperator.finalWatermarks[i].get(CustomOperator.finalWatermarks[i].size() - 1).equals(new Watermark(Long.MAX_VALUE))) {
--- End diff --
Let's add a test here that validates that this `Long.MAX_VALUE` watermark is not present. Something like `assertEquals(NUM_WATERMARKS, CustomOperator.finalWatermarks[i].size())`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3439] Remove final Long.MAX_VALUE Water...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1677#issuecomment-186397860
Good and important fix. Can you add checks as described in the comments?
Otherwise, +1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---