[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #737: nimble/ll: Use S=8 coding by default

[GitBox <gi...@apache.org>]

sjanc commented on a change in pull request #737: nimble/ll: Use S=8 coding by default
URL: https://github.com/apache/mynewt-nimble/pull/737#discussion_r371431647
 
 

 ##########
 File path: nimble/controller/include/controller/ble_phy.h
 ##########
 @@ -218,16 +216,14 @@ static inline int ble_ll_phy_to_phy_mode(int phy, int phy_options)
     int phy_mode;
 
     /*
-     * Mode values are set in a way that 1M, 2M and Coded(S=2) are equivalent
-     * to 1M, 2M and Coded in HCI. The only conversion is needed for Coded(S=8)
-     * which uses non-HCI value.
+     * 'phy' value can be used as 'phy_mode' value unless S=2 coding is explicitly
+     * required. By default we'll use S=2 for Coded.
 
 Review comment:
   S=8 ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services