You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Vjeran Marcinko (JIRA)" <ta...@jakarta.apache.org> on 2005/10/18 07:19:45 UTC
[jira] Created: (TAPESTRY-706) Button component should deprecate "label" parameter, and use informal "value" instead
Button component should deprecate "label" parameter, and use informal "value" instead
-------------------------------------------------------------------------------------
Key: TAPESTRY-706
URL: http://issues.apache.org/jira/browse/TAPESTRY-706
Project: Tapestry
Type: Bug
Components: Framework
Versions: 4.0
Environment: 4.0-beta-11
Reporter: Vjeran Marcinko
Button component should deprecate "label" parameter, and use informal "value" instead. Same as Submit component.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org
[jira] Assigned: (TAPESTRY-706) Button component should deprecate "label" parameter, and use informal "value" instead
Posted by "Howard M. Lewis Ship (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-706?page=all ]
Howard M. Lewis Ship reassigned TAPESTRY-706:
---------------------------------------------
Assign To: Howard M. Lewis Ship
> Button component should deprecate "label" parameter, and use informal "value" instead
> -------------------------------------------------------------------------------------
>
> Key: TAPESTRY-706
> URL: http://issues.apache.org/jira/browse/TAPESTRY-706
> Project: Tapestry
> Type: Bug
> Components: Framework
> Versions: 4.0
> Environment: 4.0-beta-11
> Reporter: Vjeran Marcinko
> Assignee: Howard M. Lewis Ship
>
> Button component should deprecate "label" parameter, and use informal "value" instead. Same as Submit component.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org
[jira] Commented: (TAPESTRY-706) Button component should deprecate "label" parameter, and use informal "value" instead
Posted by "Ben Dotte (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-706?page=comments#action_12356010 ]
Ben Dotte commented on TAPESTRY-706:
------------------------------------
The label parameter is already marked as deprecated in Button.jwc. But if "value" is supplied as an informal parameter it doesn't get printed on the button. There are two reasons in Button.renderFormComponent():
writer.begin("button") should be writer.begin("input")
and
if (label != null) writer.print(label) should be if (label != null) writer.attribute("value", label);
This is how the Submit component does it. Otherwise you can have problems, for example, applying a css style to the button text.
> Button component should deprecate "label" parameter, and use informal "value" instead
> -------------------------------------------------------------------------------------
>
> Key: TAPESTRY-706
> URL: http://issues.apache.org/jira/browse/TAPESTRY-706
> Project: Tapestry
> Type: Bug
> Components: Framework
> Versions: 4.0
> Environment: 4.0-beta-11
> Reporter: Vjeran Marcinko
>
> Button component should deprecate "label" parameter, and use informal "value" instead. Same as Submit component.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org
Re: [jira] Resolved: (TAPESTRY-706) Button component should deprecate "label" parameter, and use informal "value" instead
Posted by Oliver Lietz <ta...@oliverlietz.de>.
Am Samstag, 29. Oktober 2005 22:40 schrieb Howard M. Lewis Ship (JIRA):
> [ http://issues.apache.org/jira/browse/TAPESTRY-706?page=all ]
>
> Howard M. Lewis Ship resolved TAPESTRY-706:
> -------------------------------------------
>
> Resolution: Invalid
>
> There's a difference between an HTML <input type='submit"> and an HTML
> <button>. I believe what Button is doing is correct; the point of Button
> is that you can wrap it around arbitrary text and markup and all of that
> becomes the button ... but you need to add JavaScript for that button to
> actually do anything (as opposed to a submit, which will submit the
> enclosing form).
You can set button's type attribute to "submit" or "reset" instead of "button"
- so you don't need JavaScript.
Oliver
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org
[jira] Resolved: (TAPESTRY-706) Button component should deprecate "label" parameter, and use informal "value" instead
Posted by "Howard M. Lewis Ship (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-706?page=all ]
Howard M. Lewis Ship resolved TAPESTRY-706:
-------------------------------------------
Resolution: Invalid
There's a difference between an HTML <input type='submit"> and an HTML <button>. I believe what Button is doing is correct; the point of Button is that you can wrap it around arbitrary text and markup and all of that becomes the button ... but you need to add JavaScript for that button to actually do anything (as opposed to a submit, which will submit the enclosing form).
> Button component should deprecate "label" parameter, and use informal "value" instead
> -------------------------------------------------------------------------------------
>
> Key: TAPESTRY-706
> URL: http://issues.apache.org/jira/browse/TAPESTRY-706
> Project: Tapestry
> Type: Bug
> Components: Framework
> Versions: 4.0
> Environment: 4.0-beta-11
> Reporter: Vjeran Marcinko
> Assignee: Howard M. Lewis Ship
>
> Button component should deprecate "label" parameter, and use informal "value" instead. Same as Submit component.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org