You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/01/29 12:53:46 UTC
[GitHub] [cloudstack] slavkap opened a new pull request #4631: fix: create template with Marvin
slavkap opened a new pull request #4631:
URL: https://github.com/apache/cloudstack/pull/4631
Fixes problems with:
* undefined params
* if we define those params when invoking the functions
create_from_volume/create_from_snapshot will be created two templates
* according to the API docs and some digging into the code createTemplate command does not accept account and
domainid
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X ] Minor
- [ ] Trivial
### How Has This Been Tested?
execute nose tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4631: fix: create template with Marvin
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4631:
URL: https://github.com/apache/cloudstack/pull/4631#issuecomment-770683436
@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4631: fix: create template with Marvin
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4631:
URL: https://github.com/apache/cloudstack/pull/4631#issuecomment-771989892
<b>Trillian test result (tid-3470)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42168 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4631-t3470-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_deploy_kubernetes_cluster | `Failure` | 3614.08 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 113.89 | test_kubernetes_clusters.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4631: fix: create template with Marvin
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4631:
URL: https://github.com/apache/cloudstack/pull/4631#issuecomment-771476705
@slavkap i agree about those. retrying the kvm test as it failed to start
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4631: fix: create template with Marvin
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4631:
URL: https://github.com/apache/cloudstack/pull/4631#issuecomment-770682076
@blueorangutan test matrix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4631: fix: create template with Marvin
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4631:
URL: https://github.com/apache/cloudstack/pull/4631#issuecomment-769882464
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2622
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4631: fix: create template with Marvin
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4631:
URL: https://github.com/apache/cloudstack/pull/4631#issuecomment-769849967
@blueorangutan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4631: fix: create template with Marvin
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4631:
URL: https://github.com/apache/cloudstack/pull/4631#discussion_r638810660
##########
File path: tools/marvin/marvin/lib/base.py
##########
@@ -1521,12 +1513,12 @@ def _set_command(cls, apiclient, cmd, services, random_name=True):
raise Exception(
"Unable to find Ostype is required for creating template")
- cmd.snapshotid = snapshot.id
+ if volume:
+ cmd.volumeid = volume.id
+
+ if snapshot:
+ cmd.snapshotid = snapshot.id
- if account:
Review comment:
@slavkap dont' we need them anymore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland edited a comment on pull request #4631: fix: create template with Marvin
Posted by GitBox <gi...@apache.org>.
DaanHoogland edited a comment on pull request #4631:
URL: https://github.com/apache/cloudstack/pull/4631#issuecomment-769849967
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] slavkap commented on a change in pull request #4631: fix: create template with Marvin
Posted by GitBox <gi...@apache.org>.
slavkap commented on a change in pull request #4631:
URL: https://github.com/apache/cloudstack/pull/4631#discussion_r638817965
##########
File path: tools/marvin/marvin/lib/base.py
##########
@@ -1521,12 +1513,12 @@ def _set_command(cls, apiclient, cmd, services, random_name=True):
raise Exception(
"Unable to find Ostype is required for creating template")
- cmd.snapshotid = snapshot.id
+ if volume:
+ cmd.volumeid = volume.id
+
+ if snapshot:
+ cmd.snapshotid = snapshot.id
- if account:
Review comment:
@rhtyd, yes, there is no need to provide account/domain, according to the - [API docs ](https://cloudstack.apache.org/api/apidocs-4.15/apis/createTemplate.html)
also, I've checked the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4631: fix: create template with Marvin
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4631:
URL: https://github.com/apache/cloudstack/pull/4631#issuecomment-769850556
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] slavkap commented on pull request #4631: fix: create template with Marvin
Posted by GitBox <gi...@apache.org>.
slavkap commented on pull request #4631:
URL: https://github.com/apache/cloudstack/pull/4631#issuecomment-771447883
Hi @DaanHoogland
I have checked the logs but nowhere is used the change. Unfortunately don't have access to Xen or VMware to debug it further
for Xen it fails because of this:
test_01_scale_vm
> com.cloud.utils.exception.CloudRuntimeException: Unable to scale vm due to Catch exception com.xensource.xenapi.Types$LicenceRestriction when scaling VM:i-167-193-VM due to This operation is not allowed under your license. Please contact your support representative.
for VMware:
test_03_deploy_and_upgrade_kubernetes_cluster
> 2021-02-01 12:26:30,643 INFO [c.c.h.v.m.VirtualMachineMO] (VM-Question-Monitor-4:null) (logid:b9341113) Found that VM has a pending question that we need to answer programmatically, question id: msg.cdromdisconnect.locked, for safe operation we will automatically decline it
2021-02-01 12:26:30,837 INFO [c.c.h.v.u.VmwareHelper] (DirectAgent-1:ctx-ea9a902a 10.10.4.160, job-695, cmd: DettachCommand) (logid:b9341113) [ignored]failed to get message for exception: Connection control operation failed for disk 'ide0:0'.
2021-02-01 12:26:30,837 WARN [c.c.s.r.VmwareStorageProcessor] (DirectAgent-1:ctx-ea9a902a 10.10.4.160, job-695, cmd: DettachCommand) (logid:b9341113) AttachIsoCommand(detach) failed due to Exception: java.lang.RuntimeException
Message: Connection control operation failed for disk 'ide0:0'.
Also check if your guest os is a supported version
java.lang.RuntimeException: Connection control operation failed for disk 'ide0:0'.
> [upgrade/apply] FATAL: fatal error when trying to upgrade the etcd cluster, rolled the state back to pre-upgrade state: couldn't upgrade control plane. kubeadm has tried to recover everything into the earlier state. Errors faced: timed out waiting for the condition
To see the stack trace of this error execute with --v=5 or higher
[upgrade/config] FATAL: failed to get config map: Get https://10.1.1.163:6443/api/v1/namespaces/kube-system/configmaps/kubeadm-config: dial tcp 10.1.1.163:6443: connect: connection refused
To see the stack trace of this error execute with --v=5 or higher
test_04_change_offering_small and test_change_service_offering_for_vm_with_snapshots have failed with the same error:
> VM current state is : PowerOn. But VM should be in PowerOff state
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4631: fix: create template with Marvin
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4631:
URL: https://github.com/apache/cloudstack/pull/4631#issuecomment-791901706
@DaanHoogland is this good to merge, do we need more review/testing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4631: fix: create template with Marvin
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4631:
URL: https://github.com/apache/cloudstack/pull/4631#issuecomment-792589612
it has only my review @rhtyd. code looks good and has no relevant smoketest failures (which include sufficient volume/template tests)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4631: fix: create template with Marvin
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4631:
URL: https://github.com/apache/cloudstack/pull/4631#issuecomment-771140159
<b>Trillian test result (tid-3460)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40720 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4631-t3460-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Smoke tests completed. 83 look OK, 3 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 769.70 | test_kubernetes_clusters.py
test_04_change_offering_small | `Error` | 5.25 | test_service_offerings.py
test_change_service_offering_for_vm_with_snapshots | `Error` | 152.36 | test_vm_snapshots.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4631: fix: create template with Marvin
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4631:
URL: https://github.com/apache/cloudstack/pull/4631#issuecomment-771056113
<b>Trillian test result (tid-3458)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32549 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4631-t3458-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_scale_vm | `Failure` | 11.35 | test_scale_vm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4631: fix: create template with Marvin
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4631:
URL: https://github.com/apache/cloudstack/pull/4631#issuecomment-771476705
@slavkap i agree about those. retrying the kvm test as it failed to start
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4631: fix: create template with Marvin
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4631:
URL: https://github.com/apache/cloudstack/pull/4631
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4631: fix: create template with Marvin
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4631:
URL: https://github.com/apache/cloudstack/pull/4631#issuecomment-771477284
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4631: fix: create template with Marvin
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4631:
URL: https://github.com/apache/cloudstack/pull/4631#issuecomment-771477284
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] slavkap commented on pull request #4631: fix: create template with Marvin
Posted by GitBox <gi...@apache.org>.
slavkap commented on pull request #4631:
URL: https://github.com/apache/cloudstack/pull/4631#issuecomment-771447883
Hi @DaanHoogland
I have checked the logs but nowhere is used the change. Unfortunately don't have access to Xen or VMware to debug it further
for Xen it fails because of this:
test_01_scale_vm
> com.cloud.utils.exception.CloudRuntimeException: Unable to scale vm due to Catch exception com.xensource.xenapi.Types$LicenceRestriction when scaling VM:i-167-193-VM due to This operation is not allowed under your license. Please contact your support representative.
for VMware:
test_03_deploy_and_upgrade_kubernetes_cluster
> 2021-02-01 12:26:30,643 INFO [c.c.h.v.m.VirtualMachineMO] (VM-Question-Monitor-4:null) (logid:b9341113) Found that VM has a pending question that we need to answer programmatically, question id: msg.cdromdisconnect.locked, for safe operation we will automatically decline it
2021-02-01 12:26:30,837 INFO [c.c.h.v.u.VmwareHelper] (DirectAgent-1:ctx-ea9a902a 10.10.4.160, job-695, cmd: DettachCommand) (logid:b9341113) [ignored]failed to get message for exception: Connection control operation failed for disk 'ide0:0'.
2021-02-01 12:26:30,837 WARN [c.c.s.r.VmwareStorageProcessor] (DirectAgent-1:ctx-ea9a902a 10.10.4.160, job-695, cmd: DettachCommand) (logid:b9341113) AttachIsoCommand(detach) failed due to Exception: java.lang.RuntimeException
Message: Connection control operation failed for disk 'ide0:0'.
Also check if your guest os is a supported version
java.lang.RuntimeException: Connection control operation failed for disk 'ide0:0'.
> [upgrade/apply] FATAL: fatal error when trying to upgrade the etcd cluster, rolled the state back to pre-upgrade state: couldn't upgrade control plane. kubeadm has tried to recover everything into the earlier state. Errors faced: timed out waiting for the condition
To see the stack trace of this error execute with --v=5 or higher
[upgrade/config] FATAL: failed to get config map: Get https://10.1.1.163:6443/api/v1/namespaces/kube-system/configmaps/kubeadm-config: dial tcp 10.1.1.163:6443: connect: connection refused
To see the stack trace of this error execute with --v=5 or higher
test_04_change_offering_small and test_change_service_offering_for_vm_with_snapshots have failed with the same error:
> VM current state is : PowerOn. But VM should be in PowerOff state
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org