[GitHub] nickwallen commented on issue #1288: METRON-1916 Stellar Classpath Function Resolver Should Handle ClassNotFoundException

[GitBox <gi...@apache.org>]

nickwallen commented on issue #1288: METRON-1916 Stellar Classpath Function Resolver Should Handle ClassNotFoundException
URL: https://github.com/apache/metron/pull/1288#issuecomment-449483712
 
 
   The recent issue with [METRON-1953](https://issues.apache.org/jira/browse/METRON-1953) highlights how this PR would change the behavior.  
   
   Had this PR been merged, the REPL would not have blown-up and failed immediately due to that bug.  An error would have occurred only if the user called the function that requires the missing Kraken dependency.
   
   But is that a good thing?  On the positive side, a dependency that I don't care about does not impact me if I am not using a particular function.  If I am not using the function, why should I have to track down an obscure library like Kraken?
   
   On the other hand, it is nice to fail-fast and immediately know there is a problem.  We would not have uncovered METRON-1953 today had this PR been merged.
   
   So which is better?  I am really undecided at this point.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services