You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "git-hulk (via GitHub)" <gi...@apache.org> on 2023/05/05 12:17:31 UTC
[GitHub] [incubator-kvrocks-website] git-hulk opened a new pull request, #99: Remove the CDN path to fulfill apache website compliance
git-hulk opened a new pull request, #99:
URL: https://github.com/apache/incubator-kvrocks-website/pull/99
Fix warning reports by Apache Podling Website Checker: https://whimsy.apache.org/pods/project/kvrocks
Those CDN links were introduced in PR #85
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] tisonkun commented on a diff in pull request #99: Remove the CDN path to fulfill apache website compliance
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #99:
URL: https://github.com/apache/incubator-kvrocks-website/pull/99#discussion_r1186068851
##########
src/cdn.ts:
##########
@@ -3,11 +3,5 @@ export function resolveStaticAssetsURL(path: string) {
path = '/' + path;
}
- if (process.env.NODE_ENV === 'development') {
- return path;
- }
-
- // The DNS for cdn.jsdelivr.net and fastly.jsdelivr.net cannot be accessed from some regions.
- // For now, gcore.jsdelivr.net is still accessible, but its future availability is uncertain.
- return 'https://gcore.jsdelivr.net/gh/apache/incubator-kvrocks-website@main/static' + path;
+ return path
Review Comment:
Then we don't event need all of this stuff. I'll push a commit to fix up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] tisonkun commented on pull request #99: Remove the CDN path to fulfill apache website compliance
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #99:
URL: https://github.com/apache/incubator-kvrocks-website/pull/99#issuecomment-1536243488
Cross-refer to https://github.com/apache/incubator-kvrocks-website/commit/3a808b2e73995c982fc059260651410f89875cdb.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] PragmaTwice merged pull request #99: Remove the CDN path to fulfill apache website compliance
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice merged PR #99:
URL: https://github.com/apache/incubator-kvrocks-website/pull/99
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org