You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gora.apache.org by "John Mora (JIRA)" <ji...@apache.org> on 2019/05/23 05:03:00 UTC

[jira] [Commented] (GORA-393) bin/compile-examples.sh should do a touch on source files before compiling

    [ https://issues.apache.org/jira/browse/GORA-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16846424#comment-16846424 ] 

John Mora commented on GORA-393:
--------------------------------

Hi [~alfonso.nishikawa]

I was wondering if there is some pending task in this issue? I was checking bin/compile-examples.sh and it seems that the generated .java files are deleted prior to compilation which force the regeneration. Also the typo that you mention looks to be fixed.

Regards,
John

> bin/compile-examples.sh should do a touch on source files before compiling
> --------------------------------------------------------------------------
>
>                 Key: GORA-393
>                 URL: https://issues.apache.org/jira/browse/GORA-393
>             Project: Apache Gora
>          Issue Type: Improvement
>          Components: build process
>    Affects Versions: 0.3, 0.4, 0.5
>            Reporter: Alfonso Nishikawa
>            Priority: Trivial
>              Labels: compiler
>             Fix For: 1.0
>
>
> {{bin/compile-examples.sh}} is used to regenerate the examples entities after modifying the compiler.
> When the schemas are not modified, avro compiler don't overwrite the destination .java classes.
> If we 'touch' the source files we will force the regeneration of the entities always. Just a convenience modification.
> (I noticed now a typo in that script. In [line 41|https://github.com/apache/gora/blob/master/bin/compile-examples.sh#L41] must be used the command {{goracompiler}})



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)