[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #254: Truncate stats from Parquet files

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #254: Truncate stats from Parquet files
URL: https://github.com/apache/incubator-iceberg/pull/254#discussion_r300764645
 
 

 ##########
 File path: api/src/main/java/org/apache/iceberg/types/Comparators.java
 ##########
 @@ -182,13 +183,39 @@ public int compare(ByteBuffer buf1, ByteBuffer buf2) {
     private CharSeqComparator() {
     }
 
+    private boolean isCharInUTF16HighSurrogateRange(char c1) {
 
 Review comment:
   Here's an example, I think this was removed in a later version. Similarly, the extra newline on line 201 was fixed in another version.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org