You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hudson (Jira)" <ji...@apache.org> on 2019/11/22 03:19:00 UTC

[jira] [Commented] (HBASE-23234) Provide .editorconfig based on checkstyle configuration

    [ https://issues.apache.org/jira/browse/HBASE-23234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16979806#comment-16979806 ] 

Hudson commented on HBASE-23234:
--------------------------------

Results for branch branch-2
	[build #2361 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2361/]: (x) *{color:red}-1 overall{color}*
----
details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2361//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2361//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2361//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Provide .editorconfig based on checkstyle configuration
> -------------------------------------------------------
>
>                 Key: HBASE-23234
>                 URL: https://issues.apache.org/jira/browse/HBASE-23234
>             Project: HBase
>          Issue Type: Task
>          Components: build, tooling
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>            Priority: Major
>             Fix For: 3.0.0, 2.3.0, 1.6.0
>
>
> I don't have an exhaustive analysis of the issue, but there's at least one case where check style plugin configuration disagrees with our settings in {{dev-support/hbase_eclipse_formatter.xml}}.
> Formatter settings produce this code chunk
> {noformat}
>       uncaughtExceptionHandler =
>           (t, e) -> abort("Uncaught exception in executorService thread " + t.getName(), e);
> {noformat}
> but check style wants
> {noformat}
>       uncaughtExceptionHandler =
>         (t, e) -> abort("Uncaught exception in executorService thread " + t.getName(), e);
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)