You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/03 18:54:56 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5148: arch/risc-v: Refine riscv_assert.c and arch.h

xiaoxiang781216 commented on a change in pull request #5148:
URL: https://github.com/apache/incubator-nuttx/pull/5148#discussion_r777648007



##########
File path: arch/risc-v/src/common/riscv_assert.c
##########
@@ -57,6 +57,14 @@
 #  define CONFIG_BOARD_RESET_ON_ASSERT 0
 #endif
 
+/* Format output with register width and hex */
+
+#ifdef CONFIG_ARCH_RV32
+#  define PRIxREG "8"PRIx32

Review comment:
       let's use PRIxPTR to avoid chceck CONFIG_ARCH_RV32




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org