You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org> on 2017/09/01 18:14:26 UTC
[Impala-ASF-CR] IMPALA-1641: adds an end-to-end test to capture current behavior.
Vuk Ercegovac has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7937
Change subject: IMPALA-1641: adds an end-to-end test to capture current behavior.
......................................................................
IMPALA-1641: adds an end-to-end test to capture current behavior.
Adds a test to capture the expected behavior when a table whose
backing HDFS file is cached, is then altered via ALTER TABLE .. SET LOCATION
to point to the location of another backing HDFS file.
Change-Id: I82c4894eeb35272f3b905069360dfbd49fe1255a
---
M testdata/workloads/functional-query/queries/QueryTest/alter-table-hdfs-caching.test
1 file changed, 15 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/7937/1
--
To view, visit http://gerrit.cloudera.org:8080/7937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I82c4894eeb35272f3b905069360dfbd49fe1255a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] IMPALA-1641: adds an end-to-end test to capture current behavior.
Posted by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org>.
Vuk Ercegovac has posted comments on this change.
Change subject: IMPALA-1641: adds an end-to-end test to capture current behavior.
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7937/1/testdata/workloads/functional-query/queries/QueryTest/alter-table-hdfs-caching.test
File testdata/workloads/functional-query/queries/QueryTest/alter-table-hdfs-caching.test:
Line 112: # IMPALA-1641: tests that ALTER <SRC_TABLE> SET LOCATION results in no action when
> No need for this test - we already have exactly the same one in AnalyzeDDLT
thanks for pointing out the test... agreed that this end-to-end test is redundant.
--
To view, visit http://gerrit.cloudera.org:8080/7937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82c4894eeb35272f3b905069360dfbd49fe1255a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-1641: adds an end-to-end test to capture current behavior.
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-1641: adds an end-to-end test to capture current behavior.
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7937/1/testdata/workloads/functional-query/queries/QueryTest/alter-table-hdfs-caching.test
File testdata/workloads/functional-query/queries/QueryTest/alter-table-hdfs-caching.test:
Line 112: # IMPALA-1641: tests that ALTER <SRC_TABLE> SET LOCATION results in no action when
No need for this test - we already have exactly the same one in AnalyzeDDLTest#TestAlterTableSetCached.
I think we should abandon this review and resolve the JIRA based on your latest comments.
--
To view, visit http://gerrit.cloudera.org:8080/7937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82c4894eeb35272f3b905069360dfbd49fe1255a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-1641: adds an end-to-end test to capture current behavior.
Posted by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org>.
Vuk Ercegovac has abandoned this change.
Change subject: IMPALA-1641: adds an end-to-end test to capture current behavior.
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/7937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I82c4894eeb35272f3b905069360dfbd49fe1255a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>