You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "PHILO-HE (via GitHub)" <gi...@apache.org> on 2024/08/14 02:50:06 UTC
[PR] [VL] Add a docker build job and reuse pre-built arrow libs [incubator-gluten]
PHILO-HE opened a new pull request, #6826:
URL: https://github.com/apache/incubator-gluten/pull/6826
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Add a docker build job and reuse pre-built arrow libs [incubator-gluten]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer commented on code in PR #6826:
URL: https://github.com/apache/incubator-gluten/pull/6826#discussion_r1716414091
##########
.github/workflows/velox_docker.yml:
##########
@@ -51,7 +51,7 @@ concurrency:
jobs:
build-native-lib-centos-7:
runs-on: ubuntu-20.04
- container: apache/gluten:gluten-vcpkg-builder_2024_08_05 # centos7 with dependencies installed
+ container: apache/gluten:vcpkg-centos-7
Review Comment:
Are we planning to do the same on centos 8 build?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Add a docker build job and reuse pre-built arrow libs [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6826:
URL: https://github.com/apache/incubator-gluten/pull/6826#issuecomment-2287734140
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICEGJ-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on Github Issues?
https://github.com/apache/incubator-gluten/issues
Then could you also rename ***commit message*** and ***pull request title*** in the following format?
[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}
See also:
* [Other pull requests](https://github.com/apache/incubator-gluten/pulls/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Add a docker build job and reuse pre-built arrow libs [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on code in PR #6826:
URL: https://github.com/apache/incubator-gluten/pull/6826#discussion_r1719220574
##########
dev/ci-velox-buildstatic-centos-7.sh:
##########
@@ -2,12 +2,9 @@
set -e
-yum install sudo patch java-1.8.0-openjdk-devel -y
Review Comment:
@zhouyuan, maybe we can just tell user to refer weekly build job for building from clean image. centos-7/8/9, ubuntu-20.04/22.04 are covered in that job. I will document this guide. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Add a docker build job and reuse pre-built arrow libs [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on code in PR #6826:
URL: https://github.com/apache/incubator-gluten/pull/6826#discussion_r1716454132
##########
.github/workflows/velox_docker.yml:
##########
@@ -51,7 +51,7 @@ concurrency:
jobs:
build-native-lib-centos-7:
runs-on: ubuntu-20.04
- container: apache/gluten:gluten-vcpkg-builder_2024_08_05 # centos7 with dependencies installed
+ container: apache/gluten:vcpkg-centos-7
Review Comment:
@zhztheplayer, yes, it would be better to also do this for centos-8 build. At least, those libs generated by arrow build (cpp/java) can be cached in docker to accelerate CI job when the current folder based cache miss happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Add a docker build job and reuse pre-built arrow libs [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on code in PR #6826:
URL: https://github.com/apache/incubator-gluten/pull/6826#discussion_r1719220813
##########
.github/workflows/docker_image.yml:
##########
@@ -0,0 +1,48 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Build and Push Docker Image
Review Comment:
@zhouyuan, I will do that. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Add a docker build job and reuse pre-built arrow libs [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on code in PR #6826:
URL: https://github.com/apache/incubator-gluten/pull/6826#discussion_r1719221024
##########
.github/workflows/velox_docker.yml:
##########
@@ -51,7 +51,7 @@ concurrency:
jobs:
build-native-lib-centos-7:
runs-on: ubuntu-20.04
- container: apache/gluten:gluten-vcpkg-builder_2024_08_05 # centos7 with dependencies installed
+ container: apache/gluten:vcpkg-centos-7
Review Comment:
@zhouyuan, I will try this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Add a docker build job and reuse pre-built arrow libs [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE merged PR #6826:
URL: https://github.com/apache/incubator-gluten/pull/6826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Add a docker build job and reuse pre-built arrow libs [incubator-gluten]
Posted by "GlutenPerfBot (via GitHub)" <gi...@apache.org>.
GlutenPerfBot commented on PR #6826:
URL: https://github.com/apache/incubator-gluten/pull/6826#issuecomment-2291911667
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
<table border="1" cellpadding="0" cellspacing="0">
<tbody>
<tr>
<td><font color=#000000>query</font></td>
<td><font color=#000000>log/native_master_08_15_2024_time.csv</font></td>
<td><font color=#000000>log/native_master_08_14_2024_1b619a0388_time.csv</font></td>
<td><font color=#000000>difference</font></td>
<td><font color=#000000>percentage</font></td>
</tr>
<tr>
<td><font color=#6F9915>q1</font></td>
<td><font color=#6F9915>40.51</font></td>
<td><font color=#6F9915>39.02</font></td>
<td><font color=#6F9915>-1.496</font></td>
<td><font color=#6F9915>96.31%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q2</font></td>
<td><font color=#6F9915>30.39</font></td>
<td><font color=#6F9915>29.62</font></td>
<td><font color=#6F9915>-0.770</font></td>
<td><font color=#6F9915>97.46%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q3</font></td>
<td><font color=#6F9915>53.23</font></td>
<td><font color=#6F9915>51.65</font></td>
<td><font color=#6F9915>-1.572</font></td>
<td><font color=#6F9915>97.05%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q4</font></td>
<td><font color=#6F9915>44.25</font></td>
<td><font color=#6F9915>42.92</font></td>
<td><font color=#6F9915>-1.331</font></td>
<td><font color=#6F9915>96.99%</font></td>
</tr>
<tr>
<td><font color=#F92663>q5</font></td>
<td><font color=#F92663>102.93</font></td>
<td><font color=#F92663>103.89</font></td>
<td><font color=#F92663>0.968</font></td>
<td><font color=#F92663>100.94%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q6</font></td>
<td><font color=#6F9915>12.09</font></td>
<td><font color=#6F9915>11.18</font></td>
<td><font color=#6F9915>-0.906</font></td>
<td><font color=#6F9915>92.51%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q7</font></td>
<td><font color=#6F9915>116.78</font></td>
<td><font color=#6F9915>115.76</font></td>
<td><font color=#6F9915>-1.020</font></td>
<td><font color=#6F9915>99.13%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q8</font></td>
<td><font color=#6F9915>117.10</font></td>
<td><font color=#6F9915>115.92</font></td>
<td><font color=#6F9915>-1.181</font></td>
<td><font color=#6F9915>98.99%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q9</font></td>
<td><font color=#6F9915>169.16</font></td>
<td><font color=#6F9915>168.25</font></td>
<td><font color=#6F9915>-0.910</font></td>
<td><font color=#6F9915>99.46%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q10</font></td>
<td><font color=#6F9915>66.73</font></td>
<td><font color=#6F9915>65.66</font></td>
<td><font color=#6F9915>-1.075</font></td>
<td><font color=#6F9915>98.39%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q11</font></td>
<td><font color=#6F9915>26.55</font></td>
<td><font color=#6F9915>25.87</font></td>
<td><font color=#6F9915>-0.683</font></td>
<td><font color=#6F9915>97.43%</font></td>
</tr>
<tr>
<td><font color=#F92663>q12</font></td>
<td><font color=#F92663>30.12</font></td>
<td><font color=#F92663>30.71</font></td>
<td><font color=#F92663>0.591</font></td>
<td><font color=#F92663>101.96%</font></td>
</tr>
<tr>
<td><font color=#F92663>q13</font></td>
<td><font color=#F92663>51.22</font></td>
<td><font color=#F92663>51.84</font></td>
<td><font color=#F92663>0.623</font></td>
<td><font color=#F92663>101.22%</font></td>
</tr>
<tr>
<td><font color=#F92663>q14</font></td>
<td><font color=#F92663>24.79</font></td>
<td><font color=#F92663>26.31</font></td>
<td><font color=#F92663>1.518</font></td>
<td><font color=#F92663>106.12%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q15</font></td>
<td><font color=#6F9915>54.28</font></td>
<td><font color=#6F9915>53.60</font></td>
<td><font color=#6F9915>-0.675</font></td>
<td><font color=#6F9915>98.76%</font></td>
</tr>
<tr>
<td><font color=#F92663>q16</font></td>
<td><font color=#F92663>18.18</font></td>
<td><font color=#F92663>18.19</font></td>
<td><font color=#F92663>0.007</font></td>
<td><font color=#F92663>100.04%</font></td>
</tr>
<tr>
<td><font color=#F92663>q17</font></td>
<td><font color=#F92663>130.17</font></td>
<td><font color=#F92663>130.87</font></td>
<td><font color=#F92663>0.694</font></td>
<td><font color=#F92663>100.53%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q18</font></td>
<td><font color=#6F9915>196.71</font></td>
<td><font color=#6F9915>196.20</font></td>
<td><font color=#6F9915>-0.510</font></td>
<td><font color=#6F9915>99.74%</font></td>
</tr>
<tr>
<td><font color=#F92663>q19</font></td>
<td><font color=#F92663>27.00</font></td>
<td><font color=#F92663>28.20</font></td>
<td><font color=#F92663>1.195</font></td>
<td><font color=#F92663>104.43%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q20</font></td>
<td><font color=#6F9915>47.52</font></td>
<td><font color=#6F9915>43.48</font></td>
<td><font color=#6F9915>-4.041</font></td>
<td><font color=#6F9915>91.50%</font></td>
</tr>
<tr>
<td><font color=#F92663>q21</font></td>
<td><font color=#F92663>376.64</font></td>
<td><font color=#F92663>384.72</font></td>
<td><font color=#F92663>8.076</font></td>
<td><font color=#F92663>102.14%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q22</font></td>
<td><font color=#6F9915>15.77</font></td>
<td><font color=#6F9915>15.41</font></td>
<td><font color=#6F9915>-0.367</font></td>
<td><font color=#6F9915>97.67%</font></td>
</tr>
<tr>
<td><font color=#6F9915>total</font></td>
<td><font color=#6F9915>1752.12</font></td>
<td><font color=#6F9915>1749.25</font></td>
<td><font color=#6F9915>-2.867</font></td>
<td><font color=#6F9915>99.84%</font></td>
</tr>
</tbody>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Add a docker build job and reuse pre-built arrow libs [incubator-gluten]
Posted by "zhouyuan (via GitHub)" <gi...@apache.org>.
zhouyuan commented on code in PR #6826:
URL: https://github.com/apache/incubator-gluten/pull/6826#discussion_r1719198790
##########
dev/ci-velox-buildstatic-centos-7.sh:
##########
@@ -2,12 +2,9 @@
set -e
-yum install sudo patch java-1.8.0-openjdk-devel -y
Review Comment:
Initially this is kept in case someone is using this script from a clean centos 7 image
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Add a docker build job and reuse pre-built arrow libs [incubator-gluten]
Posted by "zhouyuan (via GitHub)" <gi...@apache.org>.
zhouyuan commented on code in PR #6826:
URL: https://github.com/apache/incubator-gluten/pull/6826#discussion_r1719197728
##########
.github/workflows/docker_image.yml:
##########
@@ -0,0 +1,48 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Build and Push Docker Image
Review Comment:
can you please help to add one doc on how to use this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Add a docker build job and reuse pre-built arrow libs [incubator-gluten]
Posted by "zhouyuan (via GitHub)" <gi...@apache.org>.
zhouyuan commented on code in PR #6826:
URL: https://github.com/apache/incubator-gluten/pull/6826#discussion_r1719196864
##########
.github/workflows/velox_docker.yml:
##########
@@ -51,7 +51,7 @@ concurrency:
jobs:
build-native-lib-centos-7:
runs-on: ubuntu-20.04
- container: apache/gluten:gluten-vcpkg-builder_2024_08_05 # centos7 with dependencies installed
+ container: apache/gluten:vcpkg-centos-7
Review Comment:
can we reuse the binary on centos 7?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org