[GitHub] [skywalking] kezhenxu94 opened a new issue, #10696: [Bug] [SWCK Helm Chart] release full name doesn't respect the one in `values.yaml` file (or `--set` option)

["kezhenxu94 (via GitHub)" <gi...@apache.org>]

kezhenxu94 opened a new issue, #10696:
URL: https://github.com/apache/skywalking/issues/10696

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Apache SkyWalking Component
   
   Helm Chart (apache/skywalking-kubernetes)
   
   ### What happened
   
   We provide the `nameOverride` and `fullnameOverride` for users to customize the service/Pod names
   
   https://github.com/apache/skywalking-kubernetes/blob/670d7053aab8dfbed9e325f9f3345dc6696e6352/chart/operator/values.yaml#L55-L56
   
   but we also add a very long suffix (like `-controller-manager-metrics-service`) to the `fullnameOverride` in some resources
   
   https://github.com/apache/skywalking-kubernetes/blob/670d7053aab8dfbed9e325f9f3345dc6696e6352/chart/operator/templates/service.yaml#L22
   
   This can easily make the final name exceed the maximum allowed length (usually `64`) in Kubernetes and cause the deployment fail.
   
   We should trim the final name to 64 after we add those suffices, or remove those suffices wherever possible, for example, I don't think we need suffix `-mutating-webhook-configuration` in the `MutatingWebhookConfiguration` here
   
   https://github.com/apache/skywalking-kubernetes/blob/670d7053aab8dfbed9e325f9f3345dc6696e6352/chart/operator/templates/webhook.yaml#L22
   
   ### What you expected to happen
   
   no matter how long the release name is given, the deployment should be in success
   
   ### How to reproduce
   
   Example:
   
   ```shell
   helm -n adapter upgrade --install test-a-very-long-name-that-should-fail ./chart/operator
   ```
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] dashanji commented on issue #10696: [Bug] [SWCK Helm Chart] release full name doesn't respect the one in `values.yaml` file (or `--set` option)

["dashanji (via GitHub)" <gi...@apache.org>]

dashanji commented on issue #10696:
URL: https://github.com/apache/skywalking/issues/10696#issuecomment-1511109526

   @kezhenxu94 Thanks for pointing out the bug, I will fix it later. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng closed issue #10696: [Bug] [SWCK Helm Chart] release full name doesn't respect the one in `values.yaml` file (or `--set` option)

["wu-sheng (via GitHub)" <gi...@apache.org>]

wu-sheng closed issue #10696: [Bug] [SWCK Helm Chart] release full name doesn't respect the one in `values.yaml` file (or `--set` option)
URL: https://github.com/apache/skywalking/issues/10696


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org