You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2021/04/01 00:43:49 UTC

[GitHub] [tinkerpop] OyvindSabo commented on pull request #1400: TINKERPOP-2530: Transfer OyvindSabo/gremlint and OyvindSabo/gremlint.com to apache/tinkerpop/gremlint

OyvindSabo commented on pull request #1400:
URL: https://github.com/apache/tinkerpop/pull/1400#issuecomment-811558173


   As of today I believe all the suggested changes so far have been implemented, so here is a summary of what has been done:
   
   - The code from `OyvindSabo/gremlint` has been placed in `apache/tinkerpop/gremlint`.
   
   - The code from `OyvindSabo/gremlint.com` has been placed in `apache/tinkerpop/docs/site/home/gremlint`.
   
   - Some files in the transferred code were missing an ASF licence header. I've added the missing headers where possible and excluded the remaining from `apache-rat-plugin` in `pom.xml`, so all tests pass.
   
   - Some places in the transferred code there were links that linked back to the OyvindSabo/gremlint and OyvindSabo/gremlint.com repositories. Those have been updated to link to TinkerPop equivalents.
   
   - I've written drafts for the CHANGELOG (b9115e3) and Upgrade documentation (a1d8af8). Seeing as this code transfer is a bit different from previous changelog and upgrade documentation entries I'm not really sure how it would be customary to do this, so suggestions for improvement are welcome!
   
   - The PR does not add gremlint in the Maven build structure and does not publish it to npm. As discussed, those can be done in follow-up PRs once the basic code transfer is done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org