You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/08/04 20:47:00 UTC

[GitHub] [helix] wmorgan6796 opened a new issue, #2185: admin-webapp throws NullPointerException for every request

wmorgan6796 opened a new issue, #2185:
URL: https://github.com/apache/helix/issues/2185

   ### Describe the bug
   Every API call the admin-webapp throws a NullPointerException. It's due to the fact that mapper [here](https://github.com/apache/helix/blob/master/helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ResourceUtil.java#L50) is used in the line above it. Since Java's initialization of static members follows the order in which they're declared, the mapper hasn't been instantiated yet, causing the NullPointerException [here](https://github.com/apache/helix/blob/11846ccbfe30820a4403b90e6b115c9cdb56416a/helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ResourceUtil.java#L111)  when line 49 of that file is evaluated.
   
   ### To Reproduce
   Use any API in the admin-webapp which will return a 500 (due to the NullPointerException)
   
   ### Expected behavior
   The API shouldn't return a 500 and instead return what it should.
   
   ### Additional context
   Looks like this has been broken since 2020, but due to the Rest App 2.0, probably went unnoticed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org


[GitHub] [helix] wmorgan6796 commented on issue #2185: admin-webapp throws NullPointerException for every request

Posted by GitBox <gi...@apache.org>.
wmorgan6796 commented on issue #2185:
URL: https://github.com/apache/helix/issues/2185#issuecomment-1205870298

   Yeah I got confused by which one to use. I figured though the rest app 2.0 was the way to go, can't hurt to make the admin-webapp not completely broken


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org


[GitHub] [helix] jiajunwang commented on issue #2185: admin-webapp throws NullPointerException for every request

Posted by GitBox <gi...@apache.org>.
jiajunwang commented on issue #2185:
URL: https://github.com/apache/helix/issues/2185#issuecomment-1205816214

   Thanks for the contribution, @wmorgan6796
   
   I think the plan is to deprecate admin-webapp. The fix on admin-webapp is absolutely welcomed, but I would suggest your usecase to leverage helix-rest. Or you may find more gaps forward.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org