You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by ai...@apache.org on 2016/07/13 14:43:49 UTC
hive git commit: HIVE-14209: Add some logging info for session and
operation management (Reviewed by Chaoyu Tang)
Repository: hive
Updated Branches:
refs/heads/master 82e1551ac -> f9adb4aca
HIVE-14209: Add some logging info for session and operation management (Reviewed by Chaoyu Tang)
Project: http://git-wip-us.apache.org/repos/asf/hive/repo
Commit: http://git-wip-us.apache.org/repos/asf/hive/commit/f9adb4ac
Tree: http://git-wip-us.apache.org/repos/asf/hive/tree/f9adb4ac
Diff: http://git-wip-us.apache.org/repos/asf/hive/diff/f9adb4ac
Branch: refs/heads/master
Commit: f9adb4acaf3f452315882528163da6db98a50db6
Parents: 82e1551
Author: Aihua Xu <ai...@apache.org>
Authored: Tue Jul 12 13:38:31 2016 -0400
Committer: Aihua Xu <ai...@apache.org>
Committed: Wed Jul 13 10:42:42 2016 -0400
----------------------------------------------------------------------
.../org/apache/hive/service/cli/operation/OperationManager.java | 4 +++-
.../java/org/apache/hive/service/cli/session/SessionManager.java | 2 +-
.../org/apache/hive/service/cli/thrift/ThriftCLIService.java | 4 ++--
3 files changed, 6 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hive/blob/f9adb4ac/service/src/java/org/apache/hive/service/cli/operation/OperationManager.java
----------------------------------------------------------------------
diff --git a/service/src/java/org/apache/hive/service/cli/operation/OperationManager.java b/service/src/java/org/apache/hive/service/cli/operation/OperationManager.java
index 2f18231..c26a611 100644
--- a/service/src/java/org/apache/hive/service/cli/operation/OperationManager.java
+++ b/service/src/java/org/apache/hive/service/cli/operation/OperationManager.java
@@ -200,6 +200,7 @@ public class OperationManager extends AbstractService {
}
private void addOperation(Operation operation) {
+ LOG.info("Adding operation: " + operation.getHandle());
handleToOperation.put(operation.getHandle(), operation);
if (operation instanceof SQLOperation) {
synchronized (webuiLock) {
@@ -267,9 +268,10 @@ public class OperationManager extends AbstractService {
}
public void closeOperation(OperationHandle opHandle) throws HiveSQLException {
+ LOG.info("Closing operation: " + opHandle);
Operation operation = removeOperation(opHandle);
if (operation == null) {
- throw new HiveSQLException("Operation does not exist!");
+ throw new HiveSQLException("Operation does not exist: " + opHandle);
}
Metrics metrics = MetricsFactory.getInstance();
if (metrics != null) {
http://git-wip-us.apache.org/repos/asf/hive/blob/f9adb4ac/service/src/java/org/apache/hive/service/cli/session/SessionManager.java
----------------------------------------------------------------------
diff --git a/service/src/java/org/apache/hive/service/cli/session/SessionManager.java b/service/src/java/org/apache/hive/service/cli/session/SessionManager.java
index ad8678e..4f5a852 100644
--- a/service/src/java/org/apache/hive/service/cli/session/SessionManager.java
+++ b/service/src/java/org/apache/hive/service/cli/session/SessionManager.java
@@ -357,7 +357,7 @@ public class SessionManager extends CompositeService {
public void closeSession(SessionHandle sessionHandle) throws HiveSQLException {
HiveSession session = handleToSession.remove(sessionHandle);
if (session == null) {
- throw new HiveSQLException("Session does not exist!");
+ throw new HiveSQLException("Session does not exist: " + sessionHandle);
}
try {
session.close();
http://git-wip-us.apache.org/repos/asf/hive/blob/f9adb4ac/service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java
----------------------------------------------------------------------
diff --git a/service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java b/service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java
index 0c1114a..0dd56cb 100644
--- a/service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java
+++ b/service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java
@@ -320,7 +320,7 @@ public abstract class ThriftCLIService extends AbstractService implements TCLISe
if (context != null) {
context.setSessionHandle(sessionHandle);
}
- LOG.info("Opened a session, current sessions: " + sessionCount.incrementAndGet());
+ LOG.info("Opened a session " + sessionHandle + ", current sessions: " + sessionCount.incrementAndGet());
} catch (Exception e) {
LOG.warn("Error opening session: ", e);
resp.setStatus(HiveSQLException.toTStatus(e));
@@ -466,7 +466,7 @@ public abstract class ThriftCLIService extends AbstractService implements TCLISe
try {
SessionHandle sessionHandle = new SessionHandle(req.getSessionHandle());
cliService.closeSession(sessionHandle);
- LOG.info("Closed a session, current sessions: " + sessionCount.decrementAndGet());
+ LOG.info("Closed a session " + sessionHandle + ", current sessions: " + sessionCount.decrementAndGet());
resp.setStatus(OK_STATUS);
ThriftCLIServerContext context =
(ThriftCLIServerContext)currentServerContext.get();