You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/04 20:44:55 UTC
[GitHub] [arrow-rs] Ismail-Maj opened a new pull request, #1787: Arbitrary size concat elements utf8
Ismail-Maj opened a new pull request, #1787:
URL: https://github.com/apache/arrow-rs/pull/1787
# Which issue does this PR close?
<!---
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #1748.
# Rationale for this change
<!---
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!---
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!---
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
Should be merged after #1780.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] HaoYang670 commented on a diff in pull request #1787: Arbitrary size concat elements utf8
Posted by GitBox <gi...@apache.org>.
HaoYang670 commented on code in PR #1787:
URL: https://github.com/apache/arrow-rs/pull/1787#discussion_r893264207
##########
arrow/src/compute/kernels/concat_elements.rs:
##########
@@ -29,54 +29,76 @@ use crate::error::{ArrowError, Result};
///
/// ["Hello"] + ["World"] = ["HelloWorld"]
///
-/// ["a", "b"] + [None, "c"] = [None, "bc"]
+/// ["a", "b"] + [None, "c"] + [None, "d"] = [None, "bcd"]
/// ```
///
-/// An error will be returned if `left` and `right` have different lengths
+/// An error will be returned if the [`StringArray`] are of different lengths.
pub fn concat_elements_utf8<Offset: OffsetSizeTrait>(
- left: &GenericStringArray<Offset>,
- right: &GenericStringArray<Offset>,
+ arrays: &[&GenericStringArray<Offset>],
) -> Result<GenericStringArray<Offset>> {
- if left.len() != right.len() {
+ if arrays.len() < 2 {
Review Comment:
We should follow the pattern in `concat` kernel: https://github.com/apache/arrow-rs/blob/master/arrow/src/compute/kernels/concat.rs#L53-L61
If you prefer FP style, you could write like this (not tested):
```rust
match array {
[] => Err(...),
[arr] => Ok((arr.slice(0, arr.len())),
[arr, ..] => {// your code here},
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #1787: Arbitrary size concat elements utf8
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1787:
URL: https://github.com/apache/arrow-rs/pull/1787#issuecomment-1146685176
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1787?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1787](https://codecov.io/gh/apache/arrow-rs/pull/1787?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9b9600a) into [master](https://codecov.io/gh/apache/arrow-rs/commit/1a64677b7e368b1fed586d4f2d590eaefc5a7e1e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1a64677) will **increase** coverage by `0.00%`.
> The diff coverage is `98.55%`.
```diff
@@ Coverage Diff @@
## master #1787 +/- ##
=======================================
Coverage 83.39% 83.40%
=======================================
Files 198 198
Lines 56142 56196 +54
=======================================
+ Hits 46822 46871 +49
- Misses 9320 9325 +5
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/1787?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/compute/kernels/arithmetic.rs](https://codecov.io/gh/apache/arrow-rs/pull/1787/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy9hcml0aG1ldGljLnJz) | `90.86% <ø> (ø)` | |
| [arrow/src/compute/kernels/comparison.rs](https://codecov.io/gh/apache/arrow-rs/pull/1787/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy9jb21wYXJpc29uLnJz) | `92.45% <ø> (ø)` | |
| [arrow/src/compute/kernels/concat\_elements.rs](https://codecov.io/gh/apache/arrow-rs/pull/1787/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy9jb25jYXRfZWxlbWVudHMucnM=) | `97.36% <96.96%> (-2.64%)` | :arrow_down: |
| [arrow/src/compute/kernels/boolean.rs](https://codecov.io/gh/apache/arrow-rs/pull/1787/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy9ib29sZWFuLnJz) | `96.79% <100.00%> (ø)` | |
| [arrow/src/compute/util.rs](https://codecov.io/gh/apache/arrow-rs/pull/1787/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUvdXRpbC5ycw==) | `99.00% <100.00%> (+0.09%)` | :arrow_up: |
| [parquet/src/util/cursor.rs](https://codecov.io/gh/apache/arrow-rs/pull/1787/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvdXRpbC9jdXJzb3IucnM=) | `62.18% <0.00%> (-1.69%)` | :arrow_down: |
| [parquet/src/file/serialized\_reader.rs](https://codecov.io/gh/apache/arrow-rs/pull/1787/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvZmlsZS9zZXJpYWxpemVkX3JlYWRlci5ycw==) | `94.46% <0.00%> (-1.17%)` | :arrow_down: |
| [parquet\_derive/src/parquet\_field.rs](https://codecov.io/gh/apache/arrow-rs/pull/1787/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldF9kZXJpdmUvc3JjL3BhcnF1ZXRfZmllbGQucnM=) | `65.75% <0.00%> (-0.46%)` | :arrow_down: |
| [arrow/src/datatypes/datatype.rs](https://codecov.io/gh/apache/arrow-rs/pull/1787/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2RhdGF0eXBlcy9kYXRhdHlwZS5ycw==) | `65.42% <0.00%> (-0.38%)` | :arrow_down: |
| ... and [15 more](https://codecov.io/gh/apache/arrow-rs/pull/1787/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1787?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1787?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1a64677...9b9600a](https://codecov.io/gh/apache/arrow-rs/pull/1787?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #1787: Arbitrary size concat elements utf8
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #1787:
URL: https://github.com/apache/arrow-rs/pull/1787#issuecomment-1158056050
FYI I think @tustvold is out this week
Another way to move this PR forward might be to make this a new kernel (rather than modifying the existing `concat_elements_utf8`), perhaps something like `concat_n_elements_utf8` or `concat_elements_utf8_many`?
That way we aren't worried about a potential regression in performance and people can optimize the new kernel in the future if that is desired
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Ismail-Maj commented on a diff in pull request #1787: Arbitrary size concat elements utf8
Posted by GitBox <gi...@apache.org>.
Ismail-Maj commented on code in PR #1787:
URL: https://github.com/apache/arrow-rs/pull/1787#discussion_r892793118
##########
arrow/src/compute/kernels/concat_elements.rs:
##########
@@ -129,21 +151,50 @@ mod tests {
let left = StringArray::from(vec!["foo", "bar"]);
let right = StringArray::from(vec!["bar", "baz"]);
- let output = concat_elements_utf8(&left, &right).unwrap();
+ let output = concat_elements_utf8(&[&left, &right]).unwrap();
let expected = StringArray::from(vec!["foobar", "barbaz"]);
assert_eq!(output, expected);
}
#[test]
- fn test_string_concat_error() {
+ fn test_string_concat_error_array_length() {
let left = StringArray::from(vec!["foo", "bar"]);
let right = StringArray::from(vec!["baz"]);
- let output = concat_elements_utf8(&left, &right);
+ let output = concat_elements_utf8(&[&left, &right]);
- assert!(output.is_err());
+ assert_eq!(
+ output.unwrap_err().to_string(),
+ "Compute error: Arrays must have the same length of 2".to_string()
+ );
+ }
+
+ #[test]
+ fn test_string_concat_error_slice_length() {
+ let left = [Some("foo"), Some("bar"), None]
+ .into_iter()
+ .collect::<StringArray>();
+ assert_eq!(
+ concat_elements_utf8(&[&left]).unwrap_err().to_string(),
+ "Compute error: Arrays must have at least two elements length: 1".to_string()
+ );
+ }
+
+ #[test]
+ fn test_string_concat_multiple() {
+ let foo = &StringArray::from(vec![Some("f"), Some("o"), Some("o"), None]);
+ let bar = &StringArray::from(vec![None, Some("b"), Some("a"), Some("r")]);
+ let baz = &StringArray::from(vec![Some("b"), None, Some("a"), Some("z")]);
+
+ let output = concat_elements_utf8(&[&foo, &bar, &baz]).unwrap();
Review Comment:
```suggestion
let foo = StringArray::from(vec![Some("f"), Some("o"), Some("o"), None]);
let bar = StringArray::from(vec![None, Some("b"), Some("a"), Some("r")]);
let baz = StringArray::from(vec![Some("b"), None, Some("a"), Some("z")]);
let output = concat_elements_utf8(&[&foo, &bar, &baz]).unwrap();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Ismail-Maj commented on a diff in pull request #1787: Arbitrary size concat elements utf8
Posted by GitBox <gi...@apache.org>.
Ismail-Maj commented on code in PR #1787:
URL: https://github.com/apache/arrow-rs/pull/1787#discussion_r893380169
##########
arrow/src/compute/kernels/concat_elements.rs:
##########
@@ -29,54 +29,75 @@ use crate::error::{ArrowError, Result};
///
/// ["Hello"] + ["World"] = ["HelloWorld"]
///
-/// ["a", "b"] + [None, "c"] = [None, "bc"]
+/// ["a", "b"] + [None, "c"] + [None, "d"] = [None, "bcd"]
/// ```
///
-/// An error will be returned if `left` and `right` have different lengths
+/// An error will be returned if the [`StringArray`] are of different lengths.
pub fn concat_elements_utf8<Offset: OffsetSizeTrait>(
- left: &GenericStringArray<Offset>,
- right: &GenericStringArray<Offset>,
+ arrays: &[&GenericStringArray<Offset>],
) -> Result<GenericStringArray<Offset>> {
- if left.len() != right.len() {
+ if arrays.is_empty() {
+ return Err(ArrowError::ComputeError(
+ "concat requires input of at least one array".to_string(),
+ ));
+ }
+
+ let size = arrays[0].len();
+ if !arrays.iter().all(|array| array.len() == size) {
return Err(ArrowError::ComputeError(format!(
- "Arrays must have the same length: {} != {}",
- left.len(),
- right.len()
+ "Arrays must have the same length of {}",
+ size,
)));
}
- let output_bitmap = combine_option_bitmap(&[left.data(), right.data()], left.len())?;
-
- let left_offsets = left.value_offsets();
- let right_offsets = right.value_offsets();
-
- let left_buffer = left.value_data();
- let right_buffer = right.value_data();
- let left_values = left_buffer.as_slice();
- let right_values = right_buffer.as_slice();
+ let output_bitmap = combine_option_bitmap(
+ arrays
+ .iter()
+ .map(|a| a.data())
+ .collect::<Vec<_>>()
+ .as_slice(),
+ size,
+ )?;
+
+ let data_buffers = arrays
+ .iter()
+ .map(|array| array.value_data())
+ .collect::<Vec<_>>();
+
+ let data_values = data_buffers
+ .iter()
+ .map(|buffer| buffer.as_slice())
+ .collect::<Vec<_>>();
+
+ let mut offsets = arrays
+ .iter()
+ .map(|a| a.value_offsets().iter().peekable())
+ .collect::<Vec<_>>();
let mut output_values = BufferBuilder::<u8>::new(
- left_values.len() + right_values.len()
- - left_offsets[0].to_usize().unwrap()
- - right_offsets[0].to_usize().unwrap(),
+ data_values
+ .iter()
+ .zip(offsets.iter_mut())
+ .map(|(data, offset)| data.len() - offset.peek().unwrap().to_usize().unwrap())
Review Comment:
@tustvold will this ever panic? I'm not sure if offsets can be empty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #1787: Arbitrary size concat elements utf8
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #1787:
URL: https://github.com/apache/arrow-rs/pull/1787#discussion_r893438397
##########
arrow/src/compute/kernels/concat_elements.rs:
##########
@@ -29,54 +29,75 @@ use crate::error::{ArrowError, Result};
///
/// ["Hello"] + ["World"] = ["HelloWorld"]
///
-/// ["a", "b"] + [None, "c"] = [None, "bc"]
+/// ["a", "b"] + [None, "c"] + [None, "d"] = [None, "bcd"]
/// ```
///
-/// An error will be returned if `left` and `right` have different lengths
+/// An error will be returned if the [`StringArray`] are of different lengths.
pub fn concat_elements_utf8<Offset: OffsetSizeTrait>(
- left: &GenericStringArray<Offset>,
- right: &GenericStringArray<Offset>,
+ arrays: &[&GenericStringArray<Offset>],
) -> Result<GenericStringArray<Offset>> {
- if left.len() != right.len() {
+ if arrays.is_empty() {
+ return Err(ArrowError::ComputeError(
+ "concat requires input of at least one array".to_string(),
+ ));
+ }
+
+ let size = arrays[0].len();
+ if !arrays.iter().all(|array| array.len() == size) {
return Err(ArrowError::ComputeError(format!(
- "Arrays must have the same length: {} != {}",
- left.len(),
- right.len()
+ "Arrays must have the same length of {}",
+ size,
)));
}
- let output_bitmap = combine_option_bitmap(&[left.data(), right.data()], left.len())?;
-
- let left_offsets = left.value_offsets();
- let right_offsets = right.value_offsets();
-
- let left_buffer = left.value_data();
- let right_buffer = right.value_data();
- let left_values = left_buffer.as_slice();
- let right_values = right_buffer.as_slice();
+ let output_bitmap = combine_option_bitmap(
+ arrays
+ .iter()
+ .map(|a| a.data())
+ .collect::<Vec<_>>()
+ .as_slice(),
+ size,
+ )?;
+
+ let data_buffers = arrays
+ .iter()
+ .map(|array| array.value_data())
+ .collect::<Vec<_>>();
+
+ let data_values = data_buffers
+ .iter()
+ .map(|buffer| buffer.as_slice())
+ .collect::<Vec<_>>();
+
+ let mut offsets = arrays
+ .iter()
+ .map(|a| a.value_offsets().iter().peekable())
+ .collect::<Vec<_>>();
let mut output_values = BufferBuilder::<u8>::new(
- left_values.len() + right_values.len()
- - left_offsets[0].to_usize().unwrap()
- - right_offsets[0].to_usize().unwrap(),
+ data_values
+ .iter()
+ .zip(offsets.iter_mut())
+ .map(|(data, offset)| data.len() - offset.peek().unwrap().to_usize().unwrap())
Review Comment:
Yes, offsets can be empty. Should be a simple case of adding something like this at the top of the function
```
if arrays[0].is_empty() {
return make_empty(arrays[0].data_type())
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Ismail-Maj commented on a diff in pull request #1787: Arbitrary size concat elements utf8
Posted by GitBox <gi...@apache.org>.
Ismail-Maj commented on code in PR #1787:
URL: https://github.com/apache/arrow-rs/pull/1787#discussion_r893380169
##########
arrow/src/compute/kernels/concat_elements.rs:
##########
@@ -29,54 +29,75 @@ use crate::error::{ArrowError, Result};
///
/// ["Hello"] + ["World"] = ["HelloWorld"]
///
-/// ["a", "b"] + [None, "c"] = [None, "bc"]
+/// ["a", "b"] + [None, "c"] + [None, "d"] = [None, "bcd"]
/// ```
///
-/// An error will be returned if `left` and `right` have different lengths
+/// An error will be returned if the [`StringArray`] are of different lengths.
pub fn concat_elements_utf8<Offset: OffsetSizeTrait>(
- left: &GenericStringArray<Offset>,
- right: &GenericStringArray<Offset>,
+ arrays: &[&GenericStringArray<Offset>],
) -> Result<GenericStringArray<Offset>> {
- if left.len() != right.len() {
+ if arrays.is_empty() {
+ return Err(ArrowError::ComputeError(
+ "concat requires input of at least one array".to_string(),
+ ));
+ }
+
+ let size = arrays[0].len();
+ if !arrays.iter().all(|array| array.len() == size) {
return Err(ArrowError::ComputeError(format!(
- "Arrays must have the same length: {} != {}",
- left.len(),
- right.len()
+ "Arrays must have the same length of {}",
+ size,
)));
}
- let output_bitmap = combine_option_bitmap(&[left.data(), right.data()], left.len())?;
-
- let left_offsets = left.value_offsets();
- let right_offsets = right.value_offsets();
-
- let left_buffer = left.value_data();
- let right_buffer = right.value_data();
- let left_values = left_buffer.as_slice();
- let right_values = right_buffer.as_slice();
+ let output_bitmap = combine_option_bitmap(
+ arrays
+ .iter()
+ .map(|a| a.data())
+ .collect::<Vec<_>>()
+ .as_slice(),
+ size,
+ )?;
+
+ let data_buffers = arrays
+ .iter()
+ .map(|array| array.value_data())
+ .collect::<Vec<_>>();
+
+ let data_values = data_buffers
+ .iter()
+ .map(|buffer| buffer.as_slice())
+ .collect::<Vec<_>>();
+
+ let mut offsets = arrays
+ .iter()
+ .map(|a| a.value_offsets().iter().peekable())
+ .collect::<Vec<_>>();
let mut output_values = BufferBuilder::<u8>::new(
- left_values.len() + right_values.len()
- - left_offsets[0].to_usize().unwrap()
- - right_offsets[0].to_usize().unwrap(),
+ data_values
+ .iter()
+ .zip(offsets.iter_mut())
+ .map(|(data, offset)| data.len() - offset.peek().unwrap().to_usize().unwrap())
Review Comment:
won't panic because offset is never empty after this gets merged #1825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Ismail-Maj commented on pull request #1787: Arbitrary size concat elements utf8
Posted by GitBox <gi...@apache.org>.
Ismail-Maj commented on PR #1787:
URL: https://github.com/apache/arrow-rs/pull/1787#issuecomment-1157355349
Thank you for the review @tustvold!
I'll work on a benchmark, I'm wondering if we could use [`smallvec`](https://github.com/servo/rust-smallvec) to avoid heap allocating with only a few arrays as input.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #1787: Arbitrary size concat elements utf8
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #1787:
URL: https://github.com/apache/arrow-rs/pull/1787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Ismail-Maj commented on a diff in pull request #1787: Arbitrary size concat elements utf8
Posted by GitBox <gi...@apache.org>.
Ismail-Maj commented on code in PR #1787:
URL: https://github.com/apache/arrow-rs/pull/1787#discussion_r893310802
##########
arrow/src/compute/kernels/concat_elements.rs:
##########
@@ -29,54 +29,76 @@ use crate::error::{ArrowError, Result};
///
/// ["Hello"] + ["World"] = ["HelloWorld"]
///
-/// ["a", "b"] + [None, "c"] = [None, "bc"]
+/// ["a", "b"] + [None, "c"] + [None, "d"] = [None, "bcd"]
/// ```
///
-/// An error will be returned if `left` and `right` have different lengths
+/// An error will be returned if the [`StringArray`] are of different lengths.
pub fn concat_elements_utf8<Offset: OffsetSizeTrait>(
- left: &GenericStringArray<Offset>,
- right: &GenericStringArray<Offset>,
+ arrays: &[&GenericStringArray<Offset>],
) -> Result<GenericStringArray<Offset>> {
- if left.len() != right.len() {
+ if arrays.len() < 2 {
Review Comment:
the code is quite complex to make it work for one element, I've tried without the second condition and it works :tada:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] HaoYang670 commented on pull request #1787: Arbitrary size concat elements utf8
Posted by GitBox <gi...@apache.org>.
HaoYang670 commented on PR #1787:
URL: https://github.com/apache/arrow-rs/pull/1787#issuecomment-1158400878
> I'll work on a benchmark.
@Ismail-Maj This could be done as a follow-up PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org