You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/30 19:27:01 UTC
[GitHub] [airflow] adilkhash opened a new pull request #13990: Fix the AttributeError with text field
adilkhash opened a new pull request #13990:
URL: https://github.com/apache/airflow/pull/13990
closes: #13989
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13990: Fix the AttributeError with text field in TelegramOperator
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13990:
URL: https://github.com/apache/airflow/pull/13990#discussion_r569009380
##########
File path: airflow/providers/telegram/operators/telegram.py
##########
@@ -76,6 +74,9 @@ def __init__(
def execute(self, **kwargs) -> None:
"""Calls the TelegramHook to post the provided Telegram message"""
+ if self.text:
+ self.telegram_kwargs['text'] = self.text
Review comment:
Can you add tests to avoid regression?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] adilkhash commented on a change in pull request #13990: Fix the AttributeError with text field in TelegramOperator
Posted by GitBox <gi...@apache.org>.
adilkhash commented on a change in pull request #13990:
URL: https://github.com/apache/airflow/pull/13990#discussion_r567306209
##########
File path: airflow/providers/telegram/operators/telegram.py
##########
@@ -63,9 +63,10 @@ def __init__(
self.chat_id = chat_id
self.token = token
self.telegram_kwargs = telegram_kwargs or {}
+ self.text = text
Review comment:
i have updated the code because `text` template did not even work properly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13990: Fix the AttributeError with text field in TelegramOperator
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13990:
URL: https://github.com/apache/airflow/pull/13990#discussion_r567302951
##########
File path: airflow/providers/telegram/operators/telegram.py
##########
@@ -63,9 +63,10 @@ def __init__(
self.chat_id = chat_id
self.token = token
self.telegram_kwargs = telegram_kwargs or {}
+ self.text = text
- if text is not None:
- self.telegram_kwargs['text'] = text
+ if self.text is not None:
Review comment:
```suggestion
if text is not None:
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] adilkhash commented on a change in pull request #13990: Fix the AttributeError with text field in TelegramOperator
Posted by GitBox <gi...@apache.org>.
adilkhash commented on a change in pull request #13990:
URL: https://github.com/apache/airflow/pull/13990#discussion_r569873468
##########
File path: airflow/providers/telegram/operators/telegram.py
##########
@@ -76,6 +74,9 @@ def __init__(
def execute(self, **kwargs) -> None:
"""Calls the TelegramHook to post the provided Telegram message"""
+ if self.text:
+ self.telegram_kwargs['text'] = self.text
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] adilkhash commented on pull request #13990: Fix the AttributeError with text field in TelegramOperator
Posted by GitBox <gi...@apache.org>.
adilkhash commented on pull request #13990:
URL: https://github.com/apache/airflow/pull/13990#issuecomment-770269966
templating did even work properly, i have fixed it.
please review once again
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] adilkhash commented on a change in pull request #13990: Fix the AttributeError with text field in TelegramOperator
Posted by GitBox <gi...@apache.org>.
adilkhash commented on a change in pull request #13990:
URL: https://github.com/apache/airflow/pull/13990#discussion_r569830499
##########
File path: airflow/providers/telegram/operators/telegram.py
##########
@@ -76,6 +74,9 @@ def __init__(
def execute(self, **kwargs) -> None:
"""Calls the TelegramHook to post the provided Telegram message"""
+ if self.text:
+ self.telegram_kwargs['text'] = self.text
Review comment:
sure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13990: Fix the AttributeError with text field in TelegramOperator
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13990:
URL: https://github.com/apache/airflow/pull/13990#discussion_r567302998
##########
File path: airflow/providers/telegram/operators/telegram.py
##########
@@ -63,9 +63,10 @@ def __init__(
self.chat_id = chat_id
self.token = token
self.telegram_kwargs = telegram_kwargs or {}
+ self.text = text
- if text is not None:
- self.telegram_kwargs['text'] = text
+ if self.text is not None:
+ self.telegram_kwargs['text'] = self.text
Review comment:
```suggestion
self.telegram_kwargs['text'] =text
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13990: Fix the AttributeError with text field in TelegramOperator
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13990:
URL: https://github.com/apache/airflow/pull/13990#discussion_r567302916
##########
File path: airflow/providers/telegram/operators/telegram.py
##########
@@ -63,9 +63,10 @@ def __init__(
self.chat_id = chat_id
self.token = token
self.telegram_kwargs = telegram_kwargs or {}
+ self.text = text
- if text is not None:
- self.telegram_kwargs['text'] = text
+ if self.text is not None:
Review comment:
Can you add telegram_kwargs to template fields?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13990: Fix the AttributeError with text field in TelegramOperator
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13990:
URL: https://github.com/apache/airflow/pull/13990#discussion_r569009380
##########
File path: airflow/providers/telegram/operators/telegram.py
##########
@@ -76,6 +74,9 @@ def __init__(
def execute(self, **kwargs) -> None:
"""Calls the TelegramHook to post the provided Telegram message"""
+ if self.text:
+ self.telegram_kwargs['text'] = self.text
Review comment:
Can you add tests to avoid regression?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #13990: Fix the AttributeError with text field in TelegramOperator
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #13990:
URL: https://github.com/apache/airflow/pull/13990
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13990: Fix the AttributeError with text field
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13990:
URL: https://github.com/apache/airflow/pull/13990#issuecomment-770267928
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13990: Fix the AttributeError with text field in TelegramOperator
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13990:
URL: https://github.com/apache/airflow/pull/13990#discussion_r567302998
##########
File path: airflow/providers/telegram/operators/telegram.py
##########
@@ -63,9 +63,10 @@ def __init__(
self.chat_id = chat_id
self.token = token
self.telegram_kwargs = telegram_kwargs or {}
+ self.text = text
- if text is not None:
- self.telegram_kwargs['text'] = text
+ if self.text is not None:
+ self.telegram_kwargs['text'] = self.text
Review comment:
```suggestion
self.telegram_kwargs['text'] = text
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] adilkhash edited a comment on pull request #13990: Fix the AttributeError with text field in TelegramOperator
Posted by GitBox <gi...@apache.org>.
adilkhash edited a comment on pull request #13990:
URL: https://github.com/apache/airflow/pull/13990#issuecomment-770269966
templating did not even work properly, i have fixed it.
please review once again
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13990: Fix the AttributeError with text field in TelegramOperator
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13990:
URL: https://github.com/apache/airflow/pull/13990#discussion_r567302943
##########
File path: airflow/providers/telegram/operators/telegram.py
##########
@@ -63,9 +63,10 @@ def __init__(
self.chat_id = chat_id
self.token = token
self.telegram_kwargs = telegram_kwargs or {}
+ self.text = text
Review comment:
```suggestion
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13990: Fix the AttributeError with text field in TelegramOperator
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13990:
URL: https://github.com/apache/airflow/pull/13990#issuecomment-776662307
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org