You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/17 07:26:46 UTC
[GitHub] [airflow] mik-laj opened a new pull request #14843: Improvements for Docker Image docs
mik-laj opened a new pull request #14843:
URL: https://github.com/apache/airflow/pull/14843
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #14843: Improvements for Docker Image docs
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #14843:
URL: https://github.com/apache/airflow/pull/14843#issuecomment-846483719
Rebased.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14843: Improvements for Docker Image docs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14843:
URL: https://github.com/apache/airflow/pull/14843#issuecomment-846479266
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14843: Improvements for Docker Image docs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14843:
URL: https://github.com/apache/airflow/pull/14843#issuecomment-814489341
[The Workflow run](https://github.com/apache/airflow/actions/runs/724156059) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #14843: Improvements for Docker Image docs
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #14843:
URL: https://github.com/apache/airflow/pull/14843#issuecomment-813082517
Looks like some temporary problem from yesterday - rebasing and push --forceing now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #14843: Improvements for Docker Image docs
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #14843:
URL: https://github.com/apache/airflow/pull/14843#issuecomment-812869024
Build doc is failing @mik-laj
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #14843: Improvements for Docker Image docs
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #14843:
URL: https://github.com/apache/airflow/pull/14843
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #14843: Improvements for Docker Image docs
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #14843:
URL: https://github.com/apache/airflow/pull/14843#discussion_r595769276
##########
File path: docs/docker-stack/entrypoint.rst
##########
@@ -25,68 +25,6 @@ In some cases, you can pass environment variables to the image to trigger some o
The variables that control the "execution" behaviour start with ``_AIRFLOW`` to distinguish them
from the variables used to build the image starting with ``AIRFLOW``.
-The image entrypoint works as follows:
Review comment:
This section contains a lot of information, which is repeated again in the sections below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14843: Improvements for Docker Image docs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14843:
URL: https://github.com/apache/airflow/pull/14843#issuecomment-801433078
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14843: Improvements for Docker Image docs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14843:
URL: https://github.com/apache/airflow/pull/14843#issuecomment-814489224
[The Workflow run](https://github.com/apache/airflow/actions/runs/724151114) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org