You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by pvillard31 <gi...@git.apache.org> on 2017/08/16 12:57:15 UTC
[GitHub] nifi pull request #2091: NIFI-3484 GenerateTableFetch Should Allow for Right...
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/2091
NIFI-3484 GenerateTableFetch Should Allow for Right Boundary
To replace PR #1513
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pvillard31/nifi PR1513
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2091.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2091
----
commit dde372cf3e4179a4442088adddddbe9775108f7b
Author: patricker <pa...@gmail.com>
Date: 2017-02-15T19:11:56Z
NIFI-3484
commit e611456ba71a1ec7fd946fd3290cce2f1610aec0
Author: Pierre Villard <pi...@gmail.com>
Date: 2017-08-02T13:52:06Z
fix checkstyle issue, and added unit test showing data duplication issue
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #2091: NIFI-3484 GenerateTableFetch Should Allow for Right Bounda...
Posted by patricker <gi...@git.apache.org>.
Github user patricker commented on the issue:
https://github.com/apache/nifi/pull/2091
@pvillard31 This looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #2091: NIFI-3484 GenerateTableFetch Should Allow for Right Bounda...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2091
+1 LGTM, built and ran unit tests, also verified the correct behavior on MySQL, Oracle 11, and Postgres DBs. Thanks for the improvement! Merging to master
---
[GitHub] nifi pull request #2091: NIFI-3484 GenerateTableFetch Should Allow for Right...
Posted by patricker <gi...@git.apache.org>.
Github user patricker commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2091#discussion_r133872895
--- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java ---
@@ -112,6 +112,17 @@
.addValidator(StandardValidators.NON_NEGATIVE_INTEGER_VALIDATOR)
.build();
+ public static final PropertyDescriptor RIGHT_BOUND_WHERE = new PropertyDescriptor.Builder()
--- End diff --
I am OK with proceeding that way, though I'd feel better if I knew how many databases this has been tested on. When I wrote it my focus was on one, relatively uncommon (SAP HANA) system. It tests out fine, but I just worry about making it the default.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #2091: NIFI-3484 GenerateTableFetch Should Allow for Right...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2091#discussion_r133817061
--- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java ---
@@ -112,6 +112,17 @@
.addValidator(StandardValidators.NON_NEGATIVE_INTEGER_VALIDATOR)
.build();
+ public static final PropertyDescriptor RIGHT_BOUND_WHERE = new PropertyDescriptor.Builder()
--- End diff --
Is there any situation where we'd want this false? I'm thinking this might be another case where changing the behavior is a fix and doesn't necessarily need to offer another property to maintain original behavior.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #2091: NIFI-3484 GenerateTableFetch Should Allow for Right...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2091#discussion_r134226406
--- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java ---
@@ -112,6 +112,17 @@
.addValidator(StandardValidators.NON_NEGATIVE_INTEGER_VALIDATOR)
.build();
+ public static final PropertyDescriptor RIGHT_BOUND_WHERE = new PropertyDescriptor.Builder()
--- End diff --
I can test on Postgres and Oracle, my preference is to remove the property
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #2091: NIFI-3484 GenerateTableFetch Should Allow for Right...
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2091#discussion_r133906727
--- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java ---
@@ -112,6 +112,17 @@
.addValidator(StandardValidators.NON_NEGATIVE_INTEGER_VALIDATOR)
.build();
+ public static final PropertyDescriptor RIGHT_BOUND_WHERE = new PropertyDescriptor.Builder()
--- End diff --
On my side, I've tested it on MS SQL databases. I agree that people will likely enable this option in all cases and that's just adding a WHERE clause in the generated queries. I don't see any reason why this would not work / would break existing workflows. I'm fine with removing the property or setting it to true by default in case of unforeseen behaviours. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #2091: NIFI-3484 GenerateTableFetch Should Allow for Right...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2091
---
[GitHub] nifi pull request #2091: NIFI-3484 GenerateTableFetch Should Allow for Right...
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2091#discussion_r134329892
--- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java ---
@@ -112,6 +112,17 @@
.addValidator(StandardValidators.NON_NEGATIVE_INTEGER_VALIDATOR)
.build();
+ public static final PropertyDescriptor RIGHT_BOUND_WHERE = new PropertyDescriptor.Builder()
--- End diff --
I just removed it @mattyb149, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---