You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2023/04/23 09:26:03 UTC
[Impala-ASF-CR] IMPALA-12084: Fix INVALIDATE METADATA under unloaded db still send full db objects in LocalCatalog mode
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19787
Change subject: IMPALA-12084: Fix INVALIDATE METADATA under unloaded db still send full db objects in LocalCatalog mode
......................................................................
IMPALA-12084: Fix INVALIDATE METADATA under unloaded db still send full db objects in LocalCatalog mode
INVALIDATE METADATA under unloaded db will also add the newly added db
along with the newly added table in the catalog update. In LocalCatalog
mode, we should only send back invalidation of the db instead of the
full db object. This is a missing logic we should add in IMPALA-9936.
Tests:
- Add e2e test on LocalCatalog mode
Change-Id: I38a44f69cca20331ab31acc270c2921a7bfedae5
---
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M tests/custom_cluster/test_metadata_no_events_processing.py
2 files changed, 18 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/19787/1
--
To view, visit http://gerrit.cloudera.org:8080/19787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I38a44f69cca20331ab31acc270c2921a7bfedae5
Gerrit-Change-Number: 19787
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19787
to look at the new patch set (#2).
Change subject: IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2
......................................................................
IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2
INVALIDATE METADATA under unloaded db will also add the newly added db
along with the newly added table in the catalog update. In LocalCatalog
mode, we should only send back invalidation of the db instead of the
full db object. This is a missing logic we should have added in
IMPALA-9936.
Tests:
- Add e2e test on LocalCatalog mode
Change-Id: I38a44f69cca20331ab31acc270c2921a7bfedae5
---
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M tests/custom_cluster/test_metadata_no_events_processing.py
2 files changed, 17 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/19787/2
--
To view, visit http://gerrit.cloudera.org:8080/19787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I38a44f69cca20331ab31acc270c2921a7bfedae5
Gerrit-Change-Number: 19787
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19787 )
Change subject: IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19787/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:
http://gerrit.cloudera.org:8080/#/c/19787/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@6359
PS3, Line 6359: these
> Optional: not connected to this change but now we have 4 things in the list
Done
--
To view, visit http://gerrit.cloudera.org:8080/19787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38a44f69cca20331ab31acc270c2921a7bfedae5
Gerrit-Change-Number: 19787
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Sat, 29 Apr 2023 03:44:11 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19787 )
Change subject: IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38a44f69cca20331ab31acc270c2921a7bfedae5
Gerrit-Change-Number: 19787
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 01 May 2023 18:48:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19787 )
Change subject: IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12875/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38a44f69cca20331ab31acc270c2921a7bfedae5
Gerrit-Change-Number: 19787
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Apr 2023 23:26:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19787 )
Change subject: IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38a44f69cca20331ab31acc270c2921a7bfedae5
Gerrit-Change-Number: 19787
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 02 May 2023 13:46:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12084: Fix INVALIDATE METADATA under unloaded db still send full db objects in LocalCatalog mode
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19787 )
Change subject: IMPALA-12084: Fix INVALIDATE METADATA under unloaded db still send full db objects in LocalCatalog mode
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12841/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38a44f69cca20331ab31acc270c2921a7bfedae5
Gerrit-Change-Number: 19787
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 23 Apr 2023 09:46:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19787 )
Change subject: IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/19787/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19787/1//COMMIT_MSG@12
PS1, Line 12: full db object. This is a missing logic we should have added in
> Yeah, thanks for correcting this!
Done
http://gerrit.cloudera.org:8080/#/c/19787/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:
http://gerrit.cloudera.org:8080/#/c/19787/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@a7217
PS1, Line 7217:
> This is a no-op since it sets the version by getting the version from itsel
Ack
--
To view, visit http://gerrit.cloudera.org:8080/19787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38a44f69cca20331ab31acc270c2921a7bfedae5
Gerrit-Change-Number: 19787
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Apr 2023 23:10:52 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19787 )
Change subject: IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2
......................................................................
IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2
INVALIDATE METADATA under unloaded db will also add the newly added db
along with the newly added table in the catalog update. In LocalCatalog
mode, we should only send back invalidation of the db instead of the
full db object. This is a missing logic we should have added in
IMPALA-9936.
Tests:
- Add e2e test on LocalCatalog mode
Change-Id: I38a44f69cca20331ab31acc270c2921a7bfedae5
Reviewed-on: http://gerrit.cloudera.org:8080/19787
Reviewed-by: Daniel Becker <da...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Michael Smith <mi...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M tests/custom_cluster/test_metadata_no_events_processing.py
2 files changed, 18 insertions(+), 3 deletions(-)
Approvals:
Daniel Becker: Looks good to me, but someone else must approve
Impala Public Jenkins: Verified
Michael Smith: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/19787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I38a44f69cca20331ab31acc270c2921a7bfedae5
Gerrit-Change-Number: 19787
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-12084: Fix INVALIDATE METADATA under unloaded db still send full db objects in LocalCatalog mode
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19787 )
Change subject: IMPALA-12084: Fix INVALIDATE METADATA under unloaded db still send full db objects in LocalCatalog mode
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/19787/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19787/1//COMMIT_MSG@7
PS1, Line 7: IMPALA-12084: Fix INVALIDATE METADATA under unloaded db still send full db objects in LocalCatalog mode
nit: this title is kind of long
http://gerrit.cloudera.org:8080/#/c/19787/1//COMMIT_MSG@12
PS1, Line 12: full db object. This is a missing logic we should add in IMPALA-9936.
The last sentence implies we need to do something else. I think you meant the past-tense, as in "we should have added in IMPALA-9936", since that ticket is complete.
http://gerrit.cloudera.org:8080/#/c/19787/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:
http://gerrit.cloudera.org:8080/#/c/19787/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@a7217
PS1, Line 7217:
We really want to remove this for all calls to addDbToCatalogUpdate?
--
To view, visit http://gerrit.cloudera.org:8080/19787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38a44f69cca20331ab31acc270c2921a7bfedae5
Gerrit-Change-Number: 19787
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Apr 2023 22:55:06 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19787 )
Change subject: IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38a44f69cca20331ab31acc270c2921a7bfedae5
Gerrit-Change-Number: 19787
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 27 Apr 2023 18:18:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19787 )
Change subject: IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12897/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38a44f69cca20331ab31acc270c2921a7bfedae5
Gerrit-Change-Number: 19787
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Sat, 29 Apr 2023 04:04:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19787 )
Change subject: IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38a44f69cca20331ab31acc270c2921a7bfedae5
Gerrit-Change-Number: 19787
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 02 May 2023 08:13:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19787 )
Change subject: IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38a44f69cca20331ab31acc270c2921a7bfedae5
Gerrit-Change-Number: 19787
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 02 May 2023 16:09:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19787
to look at the new patch set (#4).
Change subject: IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2
......................................................................
IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2
INVALIDATE METADATA under unloaded db will also add the newly added db
along with the newly added table in the catalog update. In LocalCatalog
mode, we should only send back invalidation of the db instead of the
full db object. This is a missing logic we should have added in
IMPALA-9936.
Tests:
- Add e2e test on LocalCatalog mode
Change-Id: I38a44f69cca20331ab31acc270c2921a7bfedae5
---
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M tests/custom_cluster/test_metadata_no_events_processing.py
2 files changed, 18 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/19787/4
--
To view, visit http://gerrit.cloudera.org:8080/19787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I38a44f69cca20331ab31acc270c2921a7bfedae5
Gerrit-Change-Number: 19787
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19787 )
Change subject: IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9271/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/19787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38a44f69cca20331ab31acc270c2921a7bfedae5
Gerrit-Change-Number: 19787
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 02 May 2023 08:28:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19787 )
Change subject: IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/19787/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19787/1//COMMIT_MSG@7
PS1, Line 7: IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2
> nit: this title is kind of long
Done
http://gerrit.cloudera.org:8080/#/c/19787/1//COMMIT_MSG@12
PS1, Line 12: full db object. This is a missing logic we should have added in
> The last sentence implies we need to do something else. I think you meant t
Yeah, thanks for correcting this!
http://gerrit.cloudera.org:8080/#/c/19787/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:
http://gerrit.cloudera.org:8080/#/c/19787/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@a7217
PS1, Line 7217:
> We really want to remove this for all calls to addDbToCatalogUpdate?
This is a no-op since it sets the version by getting the version from itself. I think it's added by mistake.
--
To view, visit http://gerrit.cloudera.org:8080/19787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38a44f69cca20331ab31acc270c2921a7bfedae5
Gerrit-Change-Number: 19787
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Apr 2023 23:05:20 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19787 )
Change subject: IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2
......................................................................
Patch Set 3:
(1 comment)
Thanks, looks good to me. I only have a bit unrelated comment, it's up to you whether you want to implement it.
http://gerrit.cloudera.org:8080/#/c/19787/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:
http://gerrit.cloudera.org:8080/#/c/19787/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@6359
PS3, Line 6359: three
Optional: not connected to this change but now we have 4 things in the list, so we could update this. To be future proof we could change this to "these things" instead of "four things".
--
To view, visit http://gerrit.cloudera.org:8080/19787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38a44f69cca20331ab31acc270c2921a7bfedae5
Gerrit-Change-Number: 19787
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 28 Apr 2023 09:26:37 +0000
Gerrit-HasComments: Yes