[GitHub] [ignite] nizhikov commented on a change in pull request #7004: IGNITE-1606 NPE during node stop due to nullified logger in TcpCommunicationSpi

[GitBox <gi...@apache.org>]

nizhikov commented on a change in pull request #7004: IGNITE-1606 NPE during node stop due to nullified logger in TcpCommunicationSpi
URL: https://github.com/apache/ignite/pull/7004#discussion_r338944314
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/resource/GridResourceIoc.java
 ##########
 @@ -574,6 +574,16 @@ public boolean inject(Object target,
             ResourceAnnotation.IGNITE_INSTANCE,
             ResourceAnnotation.LOGGER,
             ResourceAnnotation.SERVICE
+        ),
+
+        /**
+         * Same as {@link #GENERIC} excluding {@link ResourceAnnotation#LOGGER}.
+         */
+        GENERIC_CLEANABLE(
 
 Review comment:
   Can we just exclude `LOGGER` from `GENERIC` set instead of the creation of a new set?
   New set is error-prone.
   Some contributor can forget to add new `ReourceAnnotation` to it.
   This will lead to hard to find issues.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services