You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by je...@apache.org on 2018/11/20 00:05:59 UTC

[incubator-pinot] branch master updated: Deleting extra check for deletedDir during retention (#3516)

This is an automated email from the ASF dual-hosted git repository.

jenniferdai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new 7fe991f  Deleting extra check for deletedDir during retention (#3516)
7fe991f is described below

commit 7fe991f958a6c221658fb45de53fb36f53596c7b
Author: Jennifer Dai <je...@users.noreply.github.com>
AuthorDate: Mon Nov 19 16:05:54 2018 -0800

    Deleting extra check for deletedDir during retention (#3516)
---
 .../pinot/controller/helix/core/SegmentDeletionManager.java        | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/pinot-controller/src/main/java/com/linkedin/pinot/controller/helix/core/SegmentDeletionManager.java b/pinot-controller/src/main/java/com/linkedin/pinot/controller/helix/core/SegmentDeletionManager.java
index 51e305f..0f438e3 100644
--- a/pinot-controller/src/main/java/com/linkedin/pinot/controller/helix/core/SegmentDeletionManager.java
+++ b/pinot-controller/src/main/java/com/linkedin/pinot/controller/helix/core/SegmentDeletionManager.java
@@ -203,13 +203,6 @@ public class SegmentDeletionManager {
    */
   public void removeAgedDeletedSegments(int retentionInDays) {
     if (_dataDir != null) {
-      File deletedDir = new File(_dataDir, DELETED_SEGMENTS);
-      // Check that the directory for deleted segments exists
-      if (!deletedDir.isDirectory()) {
-        LOGGER.warn("Deleted segment directory {} does not exist or it is not directory.", deletedDir.getAbsolutePath());
-        return;
-      }
-
       URI dataDirURI = ControllerConf.getUriFromPath(_dataDir);
       URI deletedDirURI = ControllerConf.getUriFromPath(StringUtil.join(File.separator, _dataDir, DELETED_SEGMENTS));
       PinotFS pinotFS = PinotFSFactory.create(dataDirURI.getScheme());


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org