You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/10 20:09:54 UTC
[GitHub] [arrow] ovr opened a new pull request #9156: ARROW-11201: [Rust][DataFusion] create_batch_empty - support more types
ovr opened a new pull request #9156:
URL: https://github.com/apache/arrow/pull/9156
Hello!
In https://github.com/apache/arrow/pull/9114, I've prepared support for `List`/`LargeList`/`FixedSizeList`, but will be great to support more types
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9156: ARROW-11201: [Rust][DataFusion] create_batch_empty - support more types
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9156:
URL: https://github.com/apache/arrow/pull/9156#issuecomment-757538568
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9156?src=pr&el=h1) Report
> Merging [#9156](https://codecov.io/gh/apache/arrow/pull/9156?src=pr&el=desc) (bb9c4b8) into [master](https://codecov.io/gh/apache/arrow/commit/9560204ecfd26caa67b04dc8d3273846c217e0d6?el=desc) (9560204) will **decrease** coverage by `0.04%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/arrow/pull/9156?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9156 +/- ##
==========================================
- Coverage 81.80% 81.76% -0.05%
==========================================
Files 214 214
Lines 51383 51410 +27
==========================================
- Hits 42034 42033 -1
- Misses 9349 9377 +28
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9156?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/datafusion/src/physical\_plan/common.rs](https://codecov.io/gh/apache/arrow/pull/9156/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2NvbW1vbi5ycw==) | `41.09% <0.00%> (-24.13%)` | :arrow_down: |
| [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9156/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `95.24% <0.00%> (-0.20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9156?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9156?src=pr&el=footer). Last update [98f01c5...67e995b](https://codecov.io/gh/apache/arrow/pull/9156?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9156: ARROW-11201: [Rust][DataFusion] create_batch_empty - support more types
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9156:
URL: https://github.com/apache/arrow/pull/9156#issuecomment-757535939
https://issues.apache.org/jira/browse/ARROW-11201
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb closed pull request #9156: ARROW-11201: [Rust][DataFusion] create_batch_empty - support more types
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #9156:
URL: https://github.com/apache/arrow/pull/9156
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove commented on pull request #9156: ARROW-11201: [Rust][DataFusion] create_batch_empty - support more types
Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #9156:
URL: https://github.com/apache/arrow/pull/9156#issuecomment-758250978
@ovr Please update the PR description - if you look at other open PRs you can get a better idea for how these are normally written. These descriptions are important because they become the commit message when the PR is merged. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io edited a comment on pull request #9156: ARROW-11201: [Rust][DataFusion] create_batch_empty - support more types
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9156:
URL: https://github.com/apache/arrow/pull/9156#issuecomment-757538568
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9156?src=pr&el=h1) Report
> Merging [#9156](https://codecov.io/gh/apache/arrow/pull/9156?src=pr&el=desc) (67e995b) into [master](https://codecov.io/gh/apache/arrow/commit/9560204ecfd26caa67b04dc8d3273846c217e0d6?el=desc) (9560204) will **increase** coverage by `0.00%`.
> The diff coverage is `73.58%`.
[](https://codecov.io/gh/apache/arrow/pull/9156?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9156 +/- ##
=======================================
Coverage 81.80% 81.81%
=======================================
Files 214 214
Lines 51383 51436 +53
=======================================
+ Hits 42034 42081 +47
- Misses 9349 9355 +6
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9156?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/datafusion/src/physical\_plan/common.rs](https://codecov.io/gh/apache/arrow/pull/9156/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2NvbW1vbi5ycw==) | `78.78% <73.58%> (+13.57%)` | :arrow_up: |
| [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9156/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `95.24% <0.00%> (-0.20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9156?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9156?src=pr&el=footer). Last update [98f01c5...67e995b](https://codecov.io/gh/apache/arrow/pull/9156?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org