You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2011/12/15 02:03:32 UTC
[jira] [Commented] (MESOS-58) Migrate build system to Autotools
(Automake and Libtool)
[ https://issues.apache.org/jira/browse/MESOS-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169901#comment-13169901 ]
jiraposter@reviews.apache.org commented on MESOS-58:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2981/#review3611
-----------------------------------------------------------
Makefile.am
<https://reviews.apache.org/r/2981/#comment8049>
I know you didn't add these spaces, but feel free to remove them here and everywhere else in this patch.
Makefile.am
<https://reviews.apache.org/r/2981/#comment8048>
s/make they're/make sure they're
Makefile.am
<https://reviews.apache.org/r/2981/#comment8063>
Where does this variable come from?
configure.ac
<https://reviews.apache.org/r/2981/#comment8051>
Let's just kill these lines.
configure.ac
<https://reviews.apache.org/r/2981/#comment8052>
Kill.
configure.ac
<https://reviews.apache.org/r/2981/#comment8808>
Can we (do we) test for python before we just invoke it?
configure.ac
<https://reviews.apache.org/r/2981/#comment8809>
Regarding my comment, does autotools give us most of what we want here?
configure.ac
<https://reviews.apache.org/r/2981/#comment8810>
Kill any extra spaces, here and everywhere else.
mesos-build-env.sh.in
<https://reviews.apache.org/r/2981/#comment8811>
I'd like to revisit how bad it would be to just use relative paths and have the build procedure copy artifacts to their necessary spot so that they work given the relative directories after building. I'm concerned about the added mental overhead of getting people used to using these extra scripts as well as exporting environmental variables (can cause frustrating issues) as well as getting this all to work with a debugger. It would be great to enumerate the issues getting the existing mesos-master, mesos-slave, etc to run to determine if we can come up with any (clever) solutions.
mesos-slave-dev.in
<https://reviews.apache.org/r/2981/#comment8812>
s/master/slave
mesos-slave-dev.in
<https://reviews.apache.org/r/2981/#comment8813>
s/master/slave
src/Makefile.am
<https://reviews.apache.org/r/2981/#comment8814>
What is this for?
src/Makefile.am
<https://reviews.apache.org/r/2981/#comment8815>
Can we do this?
src/Makefile.am
<https://reviews.apache.org/r/2981/#comment8816>
Newline.
src/Makefile.am
<https://reviews.apache.org/r/2981/#comment8817>
The rest of the file indents.
src/Makefile.am
<https://reviews.apache.org/r/2981/#comment8818>
Why the extra variable? Why not just libmesos_la_LIBADD +=? Line length?
src/Makefile.am
<https://reviews.apache.org/r/2981/#comment8819>
Wow, I didn't know MKDIR_P existed!!! Or $(@D) ... what does that mean?
src/Makefile.am
<https://reviews.apache.org/r/2981/#comment8820>
Please wrap these lines for the 80 character freaks like me.
src/common/process_utils.hpp
<https://reviews.apache.org/r/2981/#comment8821>
s/hardness/harness
src/common/webui_utils.cpp
<https://reviews.apache.org/r/2981/#comment8822>
Brace on newline.
src/java/src/org/apache/mesos/MesosSchedulerDriver.java
<https://reviews.apache.org/r/2981/#comment8824>
Put throw on new line inside braces.
src/java/src/org/apache/mesos/MesosSchedulerDriver.java
<https://reviews.apache.org/r/2981/#comment8823>
?
src/master/webui.cpp
<https://reviews.apache.org/r/2981/#comment8825>
This comment still applies, even though you moved the code.
src/slave/webui.cpp
<https://reviews.apache.org/r/2981/#comment8826>
Let's call spawnWebui start as well, the namespace says it all: utils::webui::start(...
src/tests/base_zookeeper_test.cpp
<https://reviews.apache.org/r/2981/#comment8827>
Yeah, I like the idea of a source dir and a build dir ...
src/tests/external/LxcIsolation/HoldMoreMemThanRequested.sh
<https://reviews.apache.org/r/2981/#comment8829>
Cool, so are we no longer copying these in the Makefile.am?
src/tests/external/LxcIsolation/run_scheduled_memhog_test.sh
<https://reviews.apache.org/r/2981/#comment8830>
I would have expected first running the mesos-build-env.sh script ... so it is not needed? Or is it expected that it will be run before this? If it's not needed, great!
src/tests/external/LxcIsolation/run_scheduled_memhog_test.sh
<https://reviews.apache.org/r/2981/#comment8831>
Put the args on continued newlines.
src/tests/external/SampleFrameworks/CppFramework.sh
<https://reviews.apache.org/r/2981/#comment8832>
It might be nice to stick a test in each of these files that uses one of the environment variables that is expected and print if they don't exist ... and that these files are expected to get run from the the test binary which sets up all these envs.
src/tests/external/SampleFrameworks/JavaFramework.sh
<https://reviews.apache.org/r/2981/#comment8833>
Why is this one in BUILD, but some others are in SOURCE, like the next one is in SOURCE.
src/tests/main.cpp
<https://reviews.apache.org/r/2981/#comment8828>
s/ROOT_DIR/SOURCE_DIR ?? Pretty please?
- Benjamin
On 2011-11-30 19:15:42, Charles Reiss wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2981/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-30 19:15:42)
bq.
bq.
bq. Review request for mesos, Benjamin Hindman and Andy Konwinski.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This very large patch changes the build system to use automake, libtool. This patch attempts to be feature-complete with the existing build system (exception: Solaris support).
bq.
bq. Notable changes:
bq. - Builds from source control now require configure, automake, libtool to be installed; added ./bootstrap to create configure, Makefile.ins, etc. (autoreconf will _not_ work.)
bq. - Install location are no longer under $(prefix)/mesos; instead, we follow the configure-set directories mostly, so
bq. * mesos-master, mesos-slave go into $(sbindir) which defaults to $(prefix)/sbin
bq. * mesos-local, mesos-log, mesos-mesos (framework submission) go into $(bindir) which defaults to $(prefix)/bin
bq. * mesos-launcher (utility program for LXC isolation), killtree.sh (utility program) go into $(pkglibexecdir) which defaults to $(prefix)/libexec/mesos
bq. * mesos.jar goes into $(libdir)/java which defaults to $(prefix)/lib/java
bq. * libmesos.{la,so,dylib} goes into $(libdir) which defaults to $(prefix)/lib
bq. * webui python scripts go into $(pkgdatadir) which defaults to $(prefix)/share/mesos
bq. - New configuration options for finding install locations, with defaults compiled in based on configured install location:
bq. * webui_dir
bq. * launcher_dir
bq. - Created wrapper scripts mesos-master-dev and mesos-slave-dev that set configuration environment variables suitable for running Mesos out of build directory
bq. - Tests find location of external files using MESOS_BUILD_DIR and MESOS_SOURCE_DIR environment variables set by test harness
bq. - libmesos_exec.a, libmesos_sched.a have been eliminated
bq. - configure autodetects Java by default (it can still be disabled)
bq. - Removes support for building without zookeeper?
bq. - 'make test' changes names to 'make check'.
bq.
bq. Notable things not done:
bq. - 'make dist' is broken, primarily because of third_party.
bq. - We make third_party libraries part of libmesos.la; to do this, we link (PIC) .a's and non-convenience static .la's into libmesos.la. This prevents us from building a non-shared libmesos and may not be portable to some platforms. This is not a change from what the existing build system does.
bq. - the root directory and src have separate Makefile.am's; this means that dependencies in src/ won't cause config.status to regenerate files created a configure time from .in files.
bq.
bq.
bq. This addresses bug MESOS-58.
bq. https://issues.apache.org/jira/browse/MESOS-58
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. Makefile.am PRE-CREATION
bq. Makefile.in e8dec7a
bq. bootstrap PRE-CREATION
bq. config.guess f32079a
bq. config.sub 6759825
bq. configure fc6bf00
bq. configure.ac f6b6a01
bq. include/mesos/mesos.hpp PRE-CREATION
bq. install-sh 4fbbae7
bq. m4/dummy_m4_contents PRE-CREATION
bq. mesos-build-env.sh.in PRE-CREATION
bq. mesos-master-dev.in PRE-CREATION
bq. mesos-slave-dev.in PRE-CREATION
bq. src/Makefile.am PRE-CREATION
bq. src/Makefile.in 516f128
bq. src/common/process_utils.hpp 8e55d76
bq. src/common/webui_utils.hpp PRE-CREATION
bq. src/common/webui_utils.cpp PRE-CREATION
bq. src/config/config.hpp.in 49f666a
bq. src/detector/detector.cpp ef4aff7
bq. src/examples/cpp_test_executor.cpp 9dd244e
bq. src/examples/cpp_test_framework.cpp ab02805
bq. src/examples/java/Makefile.in 6500ded
bq. src/examples/java/TestExceptionFramework.java ba39757
bq. src/examples/java/TestFramework.java e1b6032
bq. src/examples/java/TestMultipleExecutorsFramework.java a49ecbb
bq. src/examples/java/test-exception-framework PRE-CREATION
bq. src/examples/java/test-executor PRE-CREATION
bq. src/examples/java/test-framework PRE-CREATION
bq. src/examples/java/test-multiple-executors-framework PRE-CREATION
bq. src/examples/java/test_exception_framework be78062
bq. src/examples/java/test_executor d2fbb05
bq. src/examples/java/test_framework 2713b34
bq. src/examples/java/test_multiple_executors_framework 9fad319
bq. src/examples/python/test-executor PRE-CREATION
bq. src/examples/python/test-framework PRE-CREATION
bq. src/examples/python/test_executor 8d6cc64
bq. src/examples/python/test_framework 050ab90
bq. src/examples/python/test_framework.py e6893cf
bq. src/examples/test_executor.cpp PRE-CREATION
bq. src/examples/test_framework.cpp PRE-CREATION
bq. src/java/mesos.pom e5b674d
bq. src/java/mesos.pom.in PRE-CREATION
bq. src/java/src/org/apache/mesos/MesosSchedulerDriver.java 04809a6
bq. src/jvm/jvm.hpp PRE-CREATION
bq. src/jvm/jvm.cpp PRE-CREATION
bq. src/log/log.hpp e50969b
bq. src/log/network.hpp c88822c
bq. src/master/slaves_manager.cpp 3f67aa1
bq. src/master/webui.cpp c5a20d1
bq. src/python/setup.py.in 7c1f6e5
bq. src/slave/lxc_isolation_module.cpp ab0843a
bq. src/slave/webui.cpp bb1c780
bq. src/tests/base_zookeeper_test.hpp e7bb7ed
bq. src/tests/base_zookeeper_test.cpp 202b66b
bq. src/tests/external/LxcIsolation/HoldMoreMemThanRequested.sh 7b87a7b
bq. src/tests/external/LxcIsolation/ScaleUpAndDown.sh 09333e2
bq. src/tests/external/LxcIsolation/TwoSeparateTasks.sh a2e2883
bq. src/tests/external/LxcIsolation/run_scheduled_memhog_test.sh 9ac7cd5
bq. src/tests/external/SampleFrameworks/CFrameworkCmdlineParsing.sh 791cbf1
bq. src/tests/external/SampleFrameworks/CFrameworkInvalidCmdline.sh 3197c81
bq. src/tests/external/SampleFrameworks/CFrameworkInvalidEnv.sh 427b33b
bq. src/tests/external/SampleFrameworks/CppFramework.sh 968d951
bq. src/tests/external/SampleFrameworks/JavaExceptionFramework.sh bc4a4e0
bq. src/tests/external/SampleFrameworks/JavaFramework.sh db88d0b
bq. src/tests/external/SampleFrameworks/PythonFramework.sh 80a7e99
bq. src/tests/external_tests.cpp 4b08f86
bq. src/tests/main.cpp ada489d
bq. src/tests/sample_frameworks_tests.cpp 877fdf1
bq. src/tests/utils.hpp 65ce4df
bq. src/tests/utils.cpp 553ab2d
bq. src/tests/zookeeper_server.hpp cac9f0d
bq. src/tests/zookeeper_server.cpp 3927785
bq. third_party/libprocess/include/process/protobuf.hpp 7636822
bq.
bq. Diff: https://reviews.apache.org/r/2981/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Charles
bq.
bq.
> Migrate build system to Autotools (Automake and Libtool)
> --------------------------------------------------------
>
> Key: MESOS-58
> URL: https://issues.apache.org/jira/browse/MESOS-58
> Project: Mesos
> Issue Type: Improvement
> Components: build
> Reporter: Andy Konwinski
> Assignee: Benjamin Hindman
>
> Ben has been leading the effort to move the build system to Autotools. This should lead to better dependency management, cleaner and easier to understand human written build input, and a faster build.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira