You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "HuangXingBo (via GitHub)" <gi...@apache.org> on 2023/02/14 08:19:37 UTC
[GitHub] [flink] HuangXingBo opened a new pull request, #21926: [FLINK-28786][following] Fix PyFlink execution failure on Mac Os with M1 chip
HuangXingBo opened a new pull request, #21926:
URL: https://github.com/apache/flink/pull/21926
## What is the purpose of the change
*This pull request will fix PyFlink execution failure on Mac Os with M1 chip*
## Brief change log
- *If import apache_beam cython implementation failure, we will fall back to python implementation*
## Verifying this change
This change added tests and can be verified as follows:
- *Manual test*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #21926: [FLINK-28786][following] Fix PyFlink execution failure on Mac Os with M1 chip
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #21926:
URL: https://github.com/apache/flink/pull/21926#issuecomment-1429320398
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "42f2915b3ab46c15a779c6aa52d642c82d0e36be",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "42f2915b3ab46c15a779c6aa52d642c82d0e36be",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 42f2915b3ab46c15a779c6aa52d642c82d0e36be UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dianfu commented on a diff in pull request #21926: [FLINK-28786][following] Fix PyFlink execution failure on Mac Os with M1 chip
Posted by "dianfu (via GitHub)" <gi...@apache.org>.
dianfu commented on code in PR #21926:
URL: https://github.com/apache/flink/pull/21926#discussion_r1105449427
##########
flink-python/pyflink/fn_execution/__init__.py:
##########
@@ -15,3 +15,10 @@
# See the License for the specific language governing permissions and
# limitations under the License.
################################################################################
+
+import os
+
+if 'PYFLINK_CYTHON' in os.environ:
Review Comment:
What about named it to `PYFLINK_CYTHON_ENABLED`
##########
flink-python/pyflink/fn_execution/__init__.py:
##########
@@ -15,3 +15,10 @@
# See the License for the specific language governing permissions and
# limitations under the License.
################################################################################
+
+import os
+
+if 'PYFLINK_CYTHON' in os.environ:
Review Comment:
Also update the following documentation: https://nightlies.apache.org/flink/flink-docs-release-1.16/docs/dev/python/environment_variables/?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] HuangXingBo closed pull request #21926: [FLINK-28786][following] Fix PyFlink execution failure on Mac Os with M1 chip
Posted by "HuangXingBo (via GitHub)" <gi...@apache.org>.
HuangXingBo closed pull request #21926: [FLINK-28786][following] Fix PyFlink execution failure on Mac Os with M1 chip
URL: https://github.com/apache/flink/pull/21926
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org