You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2019/12/26 04:57:49 UTC

[GitHub] [lucene-solr] kkewwei opened a new pull request #1125: LUCENE-9096: Implementation of CompressingTermVectorsWriter.flushOffsets can be simpler

kkewwei opened a new pull request #1125: LUCENE-9096: Implementation of CompressingTermVectorsWriter.flushOffsets can be simpler
URL: https://github.com/apache/lucene-solr/pull/1125
 
 
   Description
   In CompressingTermVectorsWriter.flushOffsets, the calculation of sumPos and sumOffsets is a little redundant
   
   Solution
   Simplify the process.
   
   Tests
   I have no idea how to test it, I‘m really appreciate anyone giving me ideas.
   
   Checklist
   Please review the following and check all that apply:
    I have 
   - [ ] reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
   - [ ]  I have created a Jira issue and added the issue ID to my pull request title.
   - [ ] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
   - [ ]  I have developed this patch against the master branch.
   - [ ]  I have run ant precommit and the appropriate test suite.
   - [ ]  I have added tests for my changes.
   - [ ]  I have added documentation for the Ref Guide (for Solr changes only).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] jpountz merged pull request #1125: LUCENE-9096: Implementation of CompressingTermVectorsWriter.flushOffsets can be simpler

Posted by GitBox <gi...@apache.org>.
jpountz merged pull request #1125: LUCENE-9096: Implementation of CompressingTermVectorsWriter.flushOffsets can be simpler
URL: https://github.com/apache/lucene-solr/pull/1125
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] kkewwei commented on issue #1125: LUCENE-9096: Implementation of CompressingTermVectorsWriter.flushOffsets can be simpler

Posted by GitBox <gi...@apache.org>.
kkewwei commented on issue #1125: LUCENE-9096: Implementation of CompressingTermVectorsWriter.flushOffsets can be simpler
URL: https://github.com/apache/lucene-solr/pull/1125#issuecomment-570994850
 
 
   @jpountz, thank you for review the code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] kkewwei edited a comment on issue #1125: LUCENE-9096: Implementation of CompressingTermVectorsWriter.flushOffsets can be simpler

Posted by GitBox <gi...@apache.org>.
kkewwei edited a comment on issue #1125: LUCENE-9096: Implementation of CompressingTermVectorsWriter.flushOffsets can be simpler
URL: https://github.com/apache/lucene-solr/pull/1125#issuecomment-570994850
 
 
   @jpountz, thank you for reviewing the code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org