You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/09/27 18:56:46 UTC
[GitHub] [iceberg] aokolnychyi opened a new pull request #3190: Spec: Add _deleted, _spec_id, _partition metadata columns
aokolnychyi opened a new pull request #3190:
URL: https://github.com/apache/iceberg/pull/3190
This PR updates the spec to include recently added metadata columns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #3190: Spec: Add _deleted, _spec_id, _partition metadata columns
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #3190:
URL: https://github.com/apache/iceberg/pull/3190#discussion_r716966975
##########
File path: site/docs/spec.md
##########
@@ -232,6 +232,9 @@ The set of metadata columns is:
|-----------------------------|---------------|-------------|
| **`2147483646 _file`** | `string` | Path of the file in which a row is stored |
| **`2147483645 _pos`** | `long` | Ordinal position of a row in the source data file |
+| **`2147483644 _deleted`** | `boolean` | Whether the row has been deleted |
+| **`2147483643 _spec_id`** | `int` | Spec ID used to track the file containing a row |
+| **`2147483642 _partition`** | `struct` | Partition to which a row belongs to |
Review comment:
Should just be "Partition to which a row belongs"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #3190: Spec: Add _deleted, _spec_id, _partition metadata columns
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #3190:
URL: https://github.com/apache/iceberg/pull/3190#issuecomment-928180927
cc @rdblue @RussellSpitzer @jackye1995 @openinx @yyanyy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi merged pull request #3190: Spec: Add _deleted, _spec_id, _partition metadata columns
Posted by GitBox <gi...@apache.org>.
aokolnychyi merged pull request #3190:
URL: https://github.com/apache/iceberg/pull/3190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on a change in pull request #3190: Spec: Add _deleted, _spec_id, _partition metadata columns
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on a change in pull request #3190:
URL: https://github.com/apache/iceberg/pull/3190#discussion_r716981662
##########
File path: site/docs/spec.md
##########
@@ -232,6 +232,9 @@ The set of metadata columns is:
|-----------------------------|---------------|-------------|
| **`2147483646 _file`** | `string` | Path of the file in which a row is stored |
| **`2147483645 _pos`** | `long` | Ordinal position of a row in the source data file |
+| **`2147483644 _deleted`** | `boolean` | Whether the row has been deleted |
+| **`2147483643 _spec_id`** | `int` | Spec ID used to track the file containing a row |
+| **`2147483642 _partition`** | `struct` | Partition to which a row belongs to |
Review comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on a change in pull request #3190: Spec: Add _deleted, _spec_id, _partition metadata columns
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on a change in pull request #3190:
URL: https://github.com/apache/iceberg/pull/3190#discussion_r716981662
##########
File path: site/docs/spec.md
##########
@@ -232,6 +232,9 @@ The set of metadata columns is:
|-----------------------------|---------------|-------------|
| **`2147483646 _file`** | `string` | Path of the file in which a row is stored |
| **`2147483645 _pos`** | `long` | Ordinal position of a row in the source data file |
+| **`2147483644 _deleted`** | `boolean` | Whether the row has been deleted |
+| **`2147483643 _spec_id`** | `int` | Spec ID used to track the file containing a row |
+| **`2147483642 _partition`** | `struct` | Partition to which a row belongs to |
Review comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #3190: Spec: Add _deleted, _spec_id, _partition metadata columns
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #3190:
URL: https://github.com/apache/iceberg/pull/3190#issuecomment-928180666
This is a follow-up to #2984 to address [this](https://github.com/apache/iceberg/pull/2984#discussion_r716254952) comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #3190: Spec: Add _deleted, _spec_id, _partition metadata columns
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #3190:
URL: https://github.com/apache/iceberg/pull/3190#discussion_r716966975
##########
File path: site/docs/spec.md
##########
@@ -232,6 +232,9 @@ The set of metadata columns is:
|-----------------------------|---------------|-------------|
| **`2147483646 _file`** | `string` | Path of the file in which a row is stored |
| **`2147483645 _pos`** | `long` | Ordinal position of a row in the source data file |
+| **`2147483644 _deleted`** | `boolean` | Whether the row has been deleted |
+| **`2147483643 _spec_id`** | `int` | Spec ID used to track the file containing a row |
+| **`2147483642 _partition`** | `struct` | Partition to which a row belongs to |
Review comment:
Should just be "Partition to which a row belongs"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi merged pull request #3190: Spec: Add _deleted, _spec_id, _partition metadata columns
Posted by GitBox <gi...@apache.org>.
aokolnychyi merged pull request #3190:
URL: https://github.com/apache/iceberg/pull/3190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #3190: Spec: Add _deleted, _spec_id, _partition metadata columns
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #3190:
URL: https://github.com/apache/iceberg/pull/3190#issuecomment-928180666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #3190: Spec: Add _deleted, _spec_id, _partition metadata columns
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #3190:
URL: https://github.com/apache/iceberg/pull/3190#issuecomment-928204041
Thanks, @rdblue!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org