You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Alejandro Abdelnur <tu...@cloudera.com> on 2011/12/09 02:37:32 UTC

Review Request: OOZIE-617 Undeprecate SSH action and add it to latter WF schemas

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3079/
-----------------------------------------------------------

Review request for oozie.


Summary
-------

Adding back SSH action as an extension.

Added example app and documentation.

to test it run 'mvn test -Dtest=TestSshActionExecutor', but default is disable as it requires the SSH keys being set.


This addresses bug OOZIE-617.
    https://issues.apache.org/jira/browse/OOZIE-617


Diffs
-----

  trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1212211 
  trunk/client/src/main/resources/ssh-action-0.1.xsd PRE-CREATION 
  trunk/core/src/main/conf/oozie-site.xml 1212211 
  trunk/core/src/test/java/org/apache/oozie/action/ssh/TestSshActionExecutor.java 1212211 
  trunk/core/src/test/java/org/apache/oozie/action/ssh/TestSshActionExecutorAsExtension.java PRE-CREATION 
  trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1212211 
  trunk/docs/src/site/twiki/DG_SshActionExtension.twiki PRE-CREATION 
  trunk/examples/src/main/apps/ssh/job.properties PRE-CREATION 
  trunk/examples/src/main/apps/ssh/workflow.xml PRE-CREATION 
  trunk/pom.xml 1212211 

Diff: https://reviews.apache.org/r/3079/diff


Testing
-------

run testcases, deployed Oozie build and run ssh example app


Thanks,

Alejandro


Re: Review Request: OOZIE-617 Undeprecate SSH action and add it to latter WF schemas

Posted by "Angelo K. Huang" <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3079/#review3769
-----------------------------------------------------------

Ship it!


+1

looks good


trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java
<https://reviews.apache.org/r/3079/#comment8537>

    spaces


- Angelo K.


On 2011-12-09 01:41:46, Alejandro Abdelnur wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3079/
> -----------------------------------------------------------
> 
> (Updated 2011-12-09 01:41:46)
> 
> 
> Review request for oozie.
> 
> 
> Summary
> -------
> 
> Adding back SSH action as an extension.
> 
> Added example app and documentation.
> 
> to test it run 'mvn test -Dtest=TestSshActionExecutor', but default is disable as it requires the SSH keys being set.
> 
> 
> This addresses bug OOZIE-617.
>     https://issues.apache.org/jira/browse/OOZIE-617
> 
> 
> Diffs
> -----
> 
>   trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1212211 
>   trunk/client/src/main/resources/ssh-action-0.1.xsd PRE-CREATION 
>   trunk/core/src/main/conf/oozie-site.xml 1212211 
>   trunk/core/src/test/java/org/apache/oozie/action/ssh/TestSshActionExecutor.java 1212211 
>   trunk/core/src/test/java/org/apache/oozie/action/ssh/TestSshActionExecutorAsExtension.java PRE-CREATION 
>   trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1212211 
>   trunk/docs/src/site/twiki/DG_SshActionExtension.twiki PRE-CREATION 
>   trunk/examples/src/main/apps/ssh/job.properties PRE-CREATION 
>   trunk/examples/src/main/apps/ssh/workflow.xml PRE-CREATION 
>   trunk/pom.xml 1212211 
> 
> Diff: https://reviews.apache.org/r/3079/diff
> 
> 
> Testing
> -------
> 
> run testcases, deployed Oozie build and run ssh example app
> 
> 
> Thanks,
> 
> Alejandro
> 
>


Re: Review Request: OOZIE-617 Add back Ssh action as extension. (tucu)

Posted by Alejandro Abdelnur <tu...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3079/
-----------------------------------------------------------

(Updated 2011-12-09 14:33:45.478664)


Review request for oozie.


Summary (updated)
-------

Adding back SSH action as an extension.

Added example app and documentation.

to test it run 'mvn test -Dtest=TestSshActionExecutor', but default is disable as it requires the SSH keys being set.


This addresses bug OOZIE-617.
    https://issues.apache.org/jira/browse/OOZIE-617


Diffs
-----

  trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1212211 
  trunk/client/src/main/resources/ssh-action-0.1.xsd PRE-CREATION 
  trunk/core/src/main/conf/oozie-site.xml 1212211 
  trunk/core/src/test/java/org/apache/oozie/action/ssh/TestSshActionExecutor.java 1212211 
  trunk/core/src/test/java/org/apache/oozie/action/ssh/TestSshActionExecutorAsExtension.java PRE-CREATION 
  trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1212211 
  trunk/docs/src/site/twiki/DG_SshActionExtension.twiki PRE-CREATION 
  trunk/examples/src/main/apps/ssh/job.properties PRE-CREATION 
  trunk/examples/src/main/apps/ssh/workflow.xml PRE-CREATION 
  trunk/pom.xml 1212211 

Diff: https://reviews.apache.org/r/3079/diff


Testing
-------

run testcases, deployed Oozie build and run ssh example app


Thanks,

Alejandro


Re: Review Request: OOZIE-617 Undeprecate SSH action and add it to latter WF schemas

Posted by Alejandro Abdelnur <tu...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3079/
-----------------------------------------------------------

(Updated 2011-12-09 01:41:46.582610)


Review request for oozie.


Changes
-------

removing trailing spaces


Summary
-------

Adding back SSH action as an extension.

Added example app and documentation.

to test it run 'mvn test -Dtest=TestSshActionExecutor', but default is disable as it requires the SSH keys being set.


This addresses bug OOZIE-617.
    https://issues.apache.org/jira/browse/OOZIE-617


Diffs (updated)
-----

  trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1212211 
  trunk/client/src/main/resources/ssh-action-0.1.xsd PRE-CREATION 
  trunk/core/src/main/conf/oozie-site.xml 1212211 
  trunk/core/src/test/java/org/apache/oozie/action/ssh/TestSshActionExecutor.java 1212211 
  trunk/core/src/test/java/org/apache/oozie/action/ssh/TestSshActionExecutorAsExtension.java PRE-CREATION 
  trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1212211 
  trunk/docs/src/site/twiki/DG_SshActionExtension.twiki PRE-CREATION 
  trunk/examples/src/main/apps/ssh/job.properties PRE-CREATION 
  trunk/examples/src/main/apps/ssh/workflow.xml PRE-CREATION 
  trunk/pom.xml 1212211 

Diff: https://reviews.apache.org/r/3079/diff


Testing
-------

run testcases, deployed Oozie build and run ssh example app


Thanks,

Alejandro