[jira] [Created] (SOLR-15703) replace all SolrException.log usage in Solr to just call log.error(...) directly

["Chris M. Hostetter (Jira)" <ji...@apache.org>]

Chris M. Hostetter created SOLR-15703:
-----------------------------------------

             Summary: replace all SolrException.log usage in Solr to just call log.error(...) directly
                 Key: SOLR-15703
                 URL: https://issues.apache.org/jira/browse/SOLR-15703
             Project: Solr
          Issue Type: Sub-task
            Reporter: Chris M. Hostetter
            Assignee: Chris M. Hostetter


There is a lot of code in Solr that uses {{SolrException.log(log, ..)}} as a way to ensure that the resulting exception can be "ignored" in tests via {{SolrException.ignorePatterns}} / {{SolrTestCaseJ4.ignoreException()}}

This "test feature" is being cleaned up / replaced in SOLR-15697 so that _any_ log message can be "muted" - meaning we don't need this special hook/hack – we can replace all calls to {{SolrException.log(log, ..)}} with (more efficient) direct calls to {{log.error(..)}} 

But this change isn't trivially to do in a scripted/automated manner – notably many of these {{SolrException.log(log, ..)}} use string concatenation that needs to be replaced with logging parameterization to pass our {{validateLogCalls}} check.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org