You are viewing a plain text version of this content. The canonical link for it is here.

Posted to log4php-dev@logging.apache.org by "Ivan Habunek (JIRA)" <ji...@apache.org> on 2010/09/18 14:30:32 UTC

[jira] Resolved: (LOG4PHP-104) LoggerNDC: discuss sense and refactor

     [ https://issues.apache.org/jira/browse/LOG4PHP-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan Habunek resolved LOG4PHP-104.
----------------------------------

    Resolution: Fixed

I have refactored the class to use a private variable for storage and added tests.
Committed in revision 998456.

> LoggerNDC: discuss sense and refactor
> -------------------------------------
>
>                 Key: LOG4PHP-104
>                 URL: https://issues.apache.org/jira/browse/LOG4PHP-104
>             Project: Log4php
>          Issue Type: Improvement
>          Components: Code
>    Affects Versions: 2.0
>            Reporter: Christian Grobmeier
>            Assignee: Ivan Habunek
>             Fix For: 2.1
>
>
> http://ci.apache.org/projects/log4php/coverage-report/LoggerNDC.php.html
> Nested contexts are on a per thread basis. Does this make sense for PHP? If yes, there are methods named in the docs which do not exist (getNDC). Also there are still global variables and a lack of test cases. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.