You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/28 18:50:32 UTC
[GitHub] [spark] hvanhovell commented on a diff in pull request #38800: [SPARK-41264][CONNECT][PYTHON] Make Literal support more datatypes
hvanhovell commented on code in PR #38800:
URL: https://github.com/apache/spark/pull/38800#discussion_r1033931133
##########
connector/connect/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -83,59 +80,39 @@ message Expression {
// directly declare the type variation).
uint32 type_variation_reference = 51;
- message VarChar {
- string value = 1;
- uint32 length = 2;
- }
-
message Decimal {
- // little-endian twos-complement integer representation of complete value
- // (ignoring precision) Always 16 bytes in length
- bytes value = 1;
+ // the string representation.
+ string value = 1;
Review Comment:
Why not bytes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org