Re: [PR] Add headers to all API methods [polaris]

["singhpk234 (via GitHub)" <gi...@apache.org>]

singhpk234 commented on code in PR #1884:
URL: https://github.com/apache/polaris/pull/1884#discussion_r2143755209


##########
quarkus/service/src/test/java/org/apache/polaris/service/quarkus/admin/ManagementServiceTest.java:
##########
@@ -132,6 +134,7 @@ public void testUpdateCatalogWithDisallowedStorageConfig() {
             .catalogsApi()
             .createCatalog(
                 new CreateCatalogRequest(catalog),
+                Mockito.mock(HttpHeaders.class),

Review Comment:
   would be really nice if we can add some e2e test, for this ?



##########
server-templates/apiServiceImpl.mustache:
##########
@@ -26,7 +28,7 @@ It is here to remove some unsupported imports (ApiResponseMessage, openapi.tools
 }}
 /**
  * Default implementation of the {{classname}}Service. Provides default
- * implemntations for all service methods that return 501 error codes (not implemented).
+ * implementations for all service methods that return 501 error codes (not implemented).

Review Comment:
   Nice catch on the typos :) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org