[jira] Commented: (LUCENE-2510) migrate solr analysis factories to analyzers module

["Chris Male (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966896#action_12966896 ] 

Chris Male commented on LUCENE-2510:
------------------------------------

Heres a few things I think we should do as part of this work:

- Convert the factories to beans.  This will make the properties that a Factory has a great deal clearer as it won't be necessary to initialize the Factory using a Map.  It'll also increase their testability.  Part of this will require changing how Solr initializes the Factories from its XML configuration.  The simplist way is to change the attribute names in the configuration to match the bean property.

- Either move the ResourceLoader interface to Lucene, or do some fancy property injection just in Solr and remove ResourceLoading from factories.  The former option means Lucene, Solr and any future modules can all use a single consist interface for resource loading.  But it may also introduce something which isn't Lucene's responsibility.  The latter would involve the factories having List<String> properties for example, and Solr detecting this and injecting the list from its own ResourceLoader.  It introduces more complexity into Solr, but presents a very clean interface in the Factory which increases its readability, testability, and makes them more programmatically friendly.

> migrate solr analysis factories to analyzers module
> ---------------------------------------------------
>
>                 Key: LUCENE-2510
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2510
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: contrib/analyzers
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>
> In LUCENE-2413 all TokenStreams were consolidated into the analyzers module.
> This is a good step, but I think the next step is to put the Solr factories into the analyzers module, too.
> This would make analyzers artifacts plugins to both lucene and solr, with benefits such as:
> * users could use the old analyzers module with solr, too. This is a good step to use real library versions instead of Version for backwards compat.
> * analyzers modules such as smartcn and icu, that aren't currently available to solr users due to large file sizes or dependencies, would be simple optional plugins to solr and easily available to users that want them.
> Rough sketch in this thread: http://www.lucidimagination.com/search/document/3465a0e55ba94d58/solr_and_analyzers_module
> Practically, I havent looked much and don't really have a plan for how this will work yet, so ideas are very welcome.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org