You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/09/03 00:53:49 UTC

[GitHub] [incubator-tvm] yzhliu commented on pull request #6364: [Relay] Add user-defined constant node printer

yzhliu commented on pull request #6364:
URL: https://github.com/apache/incubator-tvm/pull/6364#issuecomment-686165595


   Thanks @zhiics @junrushao1994 for the suggestion. The annotator does work. However I noticed the printer of constant node prints annotation (and typer) twice. like,
   
   ```
   conv2d(%x, %conv.w, meta[relay.Constant][0] /* ty=Tensor[(1), int64] */ /* ty=Tensor[(1), int64] *
   ```
   
   Because for Print(meta=false), constant node does not know how to print itself, and fallback to Print(meta=true), the annotation therefore be added twice in `Print()`.
   
   Please advise if the fix makes sense.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org