[GitHub] [incubator-dolphinscheduler] yangruochen commented on a change in pull request #3846: [FIX-Bug #3845][Ambari Plugin] Start Ambari report an error: Table 't_ds_process_definition_version' already exists

[GitBox <gi...@apache.org>]

yangruochen commented on a change in pull request #3846:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3846#discussion_r495828488



##########
File path: sql/upgrade/1.3.3_schema/mysql/dolphinscheduler_ddl.sql
##########
@@ -101,7 +101,7 @@ drop PROCEDURE if EXISTS ct_dolphin_T_t_ds_process_definition_version;
 delimiter d//
 CREATE PROCEDURE ct_dolphin_T_t_ds_process_definition_version()
 BEGIN
-    CREATE TABLE `t_ds_process_definition_version` (
+    CREATE TABLE IF NOT EXISTS `t_ds_process_definition_version` (

Review comment:
       > I don’t know why the author of this stored procedure wants to recreate t_ds_process_definition_version here. If this is necessary, I think it`s better to modify it to
   > 
   > ```
   > drop table if exists xxx;
   > create table xxx;
   > ```
   
   I am a newer for dolphinscheduler. I just worry about that there store some values in this table. So I add IF NOT EXISTS.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org