You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by pm...@apache.org on 2019/03/25 22:49:58 UTC
[samza] branch master updated: SAMZA-2146: Expose physical name in
StreamDescriptor
This is an automated email from the ASF dual-hosted git repository.
pmaheshwari pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/samza.git
The following commit(s) were added to refs/heads/master by this push:
new e1ef7a0 SAMZA-2146: Expose physical name in StreamDescriptor
e1ef7a0 is described below
commit e1ef7a0c8882d7bcf18b57fd6e9f71076d5df247
Author: mynameborat <bh...@gmail.com>
AuthorDate: Mon Mar 25 15:49:52 2019 -0700
SAMZA-2146: Expose physical name in StreamDescriptor
Refer to https://issues.apache.org/jira/browse/SAMZA-2146 for more details
Author: mynameborat <bh...@gmail.com>
Reviewers: Manasa Gaduputi <mg...@linkedin.com>
Closes #972 from mynameborat/expose_physical_name
---
.../org/apache/samza/system/descriptors/GenericInputDescriptor.java | 5 -----
.../org/apache/samza/system/descriptors/GenericOutputDescriptor.java | 5 -----
.../java/org/apache/samza/system/descriptors/StreamDescriptor.java | 2 +-
.../test/framework/system/descriptors/InMemoryInputDescriptor.java | 5 -----
.../test/framework/system/descriptors/InMemoryOutputDescriptor.java | 5 -----
5 files changed, 1 insertion(+), 21 deletions(-)
diff --git a/samza-api/src/main/java/org/apache/samza/system/descriptors/GenericInputDescriptor.java b/samza-api/src/main/java/org/apache/samza/system/descriptors/GenericInputDescriptor.java
index e08fa09..0402a7c 100644
--- a/samza-api/src/main/java/org/apache/samza/system/descriptors/GenericInputDescriptor.java
+++ b/samza-api/src/main/java/org/apache/samza/system/descriptors/GenericInputDescriptor.java
@@ -39,9 +39,4 @@ public final class GenericInputDescriptor<StreamMessageType>
GenericInputDescriptor(String streamId, SystemDescriptor systemDescriptor, Serde serde) {
super(streamId, serde, systemDescriptor, null);
}
-
- @Override
- public GenericInputDescriptor<StreamMessageType> withPhysicalName(String physicalName) {
- return super.withPhysicalName(physicalName);
- }
}
diff --git a/samza-api/src/main/java/org/apache/samza/system/descriptors/GenericOutputDescriptor.java b/samza-api/src/main/java/org/apache/samza/system/descriptors/GenericOutputDescriptor.java
index 7302c35..762f3cb 100644
--- a/samza-api/src/main/java/org/apache/samza/system/descriptors/GenericOutputDescriptor.java
+++ b/samza-api/src/main/java/org/apache/samza/system/descriptors/GenericOutputDescriptor.java
@@ -39,9 +39,4 @@ public final class GenericOutputDescriptor<StreamMessageType>
GenericOutputDescriptor(String streamId, SystemDescriptor systemDescriptor, Serde serde) {
super(streamId, serde, systemDescriptor);
}
-
- @Override
- public GenericOutputDescriptor<StreamMessageType> withPhysicalName(String physicalName) {
- return super.withPhysicalName(physicalName);
- }
}
diff --git a/samza-api/src/main/java/org/apache/samza/system/descriptors/StreamDescriptor.java b/samza-api/src/main/java/org/apache/samza/system/descriptors/StreamDescriptor.java
index 43cab8f..a6b73a2 100644
--- a/samza-api/src/main/java/org/apache/samza/system/descriptors/StreamDescriptor.java
+++ b/samza-api/src/main/java/org/apache/samza/system/descriptors/StreamDescriptor.java
@@ -86,7 +86,7 @@ public abstract class StreamDescriptor<StreamMessageType, SubClass extends Strea
* @param physicalName physical name for this stream.
* @return this stream descriptor.
*/
- protected SubClass withPhysicalName(String physicalName) {
+ public SubClass withPhysicalName(String physicalName) {
this.physicalNameOptional = Optional.ofNullable(physicalName);
return (SubClass) this;
}
diff --git a/samza-test/src/main/java/org/apache/samza/test/framework/system/descriptors/InMemoryInputDescriptor.java b/samza-test/src/main/java/org/apache/samza/test/framework/system/descriptors/InMemoryInputDescriptor.java
index 477c35d..c446083 100644
--- a/samza-test/src/main/java/org/apache/samza/test/framework/system/descriptors/InMemoryInputDescriptor.java
+++ b/samza-test/src/main/java/org/apache/samza/test/framework/system/descriptors/InMemoryInputDescriptor.java
@@ -39,9 +39,4 @@ public class InMemoryInputDescriptor<StreamMessageType>
InMemoryInputDescriptor(String streamId, InMemorySystemDescriptor systemDescriptor) {
super(streamId, new NoOpSerde<>(), systemDescriptor, null);
}
-
- public InMemoryInputDescriptor withPhysicalName(String physicalName) {
- super.withPhysicalName(physicalName);
- return this;
- }
}
diff --git a/samza-test/src/main/java/org/apache/samza/test/framework/system/descriptors/InMemoryOutputDescriptor.java b/samza-test/src/main/java/org/apache/samza/test/framework/system/descriptors/InMemoryOutputDescriptor.java
index a86e5a1..26c64f3 100644
--- a/samza-test/src/main/java/org/apache/samza/test/framework/system/descriptors/InMemoryOutputDescriptor.java
+++ b/samza-test/src/main/java/org/apache/samza/test/framework/system/descriptors/InMemoryOutputDescriptor.java
@@ -43,9 +43,4 @@ public class InMemoryOutputDescriptor<StreamMessageType>
InMemoryOutputDescriptor(String streamId, SystemDescriptor systemDescriptor) {
super(streamId, new NoOpSerde<>(), systemDescriptor);
}
-
- public InMemoryOutputDescriptor withPhysicalName(String physicalName) {
- super.withPhysicalName(physicalName);
- return this;
- }
}