You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/12/29 02:39:37 UTC

[kudu-CR] [c++] remove the -Wno-deprecated compiler's flag 

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12140


Change subject: [c++] remove the -Wno-deprecated compiler's flag
......................................................................

[c++] remove the -Wno-deprecated compiler's flag

Removed the -Wno-deprecated compiler's flag, replaced some of the
deprecated Kudu API calls with the contemporary counterparts and
added 'pragma GCC diagnostic' blocks elsewhere.

The motivation for this change was too many warnings produced by
the compilation of the python Kudu client (originated from client.h).

Change-Id: I513bd49642755dbcb7ed405391fb13096ee49759
---
M CMakeLists.txt
M src/kudu/benchmarks/tpch/rpc_line_item_dao.cc
M src/kudu/client/client-test-util.cc
M src/kudu/client/client-test.cc
M src/kudu/client/scan_token-internal.cc
M src/kudu/client/scan_token-test.cc
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/integration-tests/all_types-itest.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/integration-tests/cluster_verifier.cc
M src/kudu/integration-tests/create-table-stress-test.cc
M src/kudu/integration-tests/delete_table-itest.cc
M src/kudu/integration-tests/flex_partitioning-itest.cc
M src/kudu/integration-tests/full_stack-insert-scan-test.cc
M src/kudu/integration-tests/fuzz-itest.cc
M src/kudu/integration-tests/heavy-update-compaction-itest.cc
M src/kudu/integration-tests/linked_list-test-util.h
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/test_workload.cc
M src/kudu/integration-tests/update_scan_delta_compact-test.cc
M src/kudu/tools/ksck_remote-test.cc
22 files changed, 204 insertions(+), 141 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/12140/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I513bd49642755dbcb7ed405391fb13096ee49759
Gerrit-Change-Number: 12140
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [c++] remove -Wno-deprecated compiler's flag

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12140 )

Change subject: [c++] remove -Wno-deprecated compiler's flag
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12140/3/src/kudu/client/schema.h
File src/kudu/client/schema.h:

http://gerrit.cloudera.org:8080/#/c/12140/3/src/kudu/client/schema.h@254
PS3, Line 254:   (defined(COMPILER_GCC) && (__GNUC__ * 10000 + __GNUC_MINOR__ * 100) >= 40600)
I see we use COMPILER_GCC elsewhere in the codebase, but I don't think it's actually defined. It's not a standard definition as per the gcc documentation, nor does it appear to be defined in my gcc:

  $ g++ -dM -E -x c++ - < /dev/null | grep COMPILER_GCC
  $ gcc -dM -E - < /dev/null | grep COMPILER_GCC

I suspect it's from imported Chromium/Supersonic code, and that it's defined centrally in that codebase somewhere.



-- 
To view, visit http://gerrit.cloudera.org:8080/12140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I513bd49642755dbcb7ed405391fb13096ee49759
Gerrit-Change-Number: 12140
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 04 Jan 2019 19:35:30 +0000
Gerrit-HasComments: Yes

[kudu-CR] [c++] remove -Wno-deprecated compiler's flag

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12140 )

Change subject: [c++] remove -Wno-deprecated compiler's flag
......................................................................


Patch Set 3: Verified+1

Unrelated flake in ConcurrentRebalancersTest.TwoConcurrentRebalancers/1


-- 
To view, visit http://gerrit.cloudera.org:8080/12140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I513bd49642755dbcb7ed405391fb13096ee49759
Gerrit-Change-Number: 12140
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 04 Jan 2019 03:05:04 +0000
Gerrit-HasComments: No

[kudu-CR] [c++] remove -Wno-deprecated compiler's flag

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12140 )

Change subject: [c++] remove -Wno-deprecated compiler's flag
......................................................................


Patch Set 4: Code-Review+2

Please test the C++ samples build on an el6.6 machine to make sure you get the desired behavior in client/schema.h.


-- 
To view, visit http://gerrit.cloudera.org:8080/12140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I513bd49642755dbcb7ed405391fb13096ee49759
Gerrit-Change-Number: 12140
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 04 Jan 2019 22:24:19 +0000
Gerrit-HasComments: No

[kudu-CR] [c++] remove -Wno-deprecated compiler's flag

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12140 )

Change subject: [c++] remove -Wno-deprecated compiler's flag
......................................................................

[c++] remove -Wno-deprecated compiler's flag

Removed -Wno-deprecated compiler's flag, replaced some of the
deprecated Kudu API calls with their contemporary counterparts and
added 'pragma GCC diagnostic' blocks elsewhere.

The motivation for this change was seeing too many warnings
while building the python Kudu client.

Change-Id: I513bd49642755dbcb7ed405391fb13096ee49759
Reviewed-on: http://gerrit.cloudera.org:8080/12140
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M CMakeLists.txt
M src/kudu/benchmarks/tpch/rpc_line_item_dao.cc
M src/kudu/client/client-test-util.cc
M src/kudu/client/client-test.cc
M src/kudu/client/scan_token-internal.cc
M src/kudu/client/scan_token-test.cc
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/integration-tests/all_types-itest.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/integration-tests/cluster_verifier.cc
M src/kudu/integration-tests/create-table-stress-test.cc
M src/kudu/integration-tests/delete_table-itest.cc
M src/kudu/integration-tests/flex_partitioning-itest.cc
M src/kudu/integration-tests/full_stack-insert-scan-test.cc
M src/kudu/integration-tests/fuzz-itest.cc
M src/kudu/integration-tests/heavy-update-compaction-itest.cc
M src/kudu/integration-tests/linked_list-test-util.h
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/test_workload.cc
M src/kudu/integration-tests/update_scan_delta_compact-test.cc
M src/kudu/tools/ksck_remote-test.cc
22 files changed, 216 insertions(+), 146 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/12140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I513bd49642755dbcb7ed405391fb13096ee49759
Gerrit-Change-Number: 12140
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] [c++] remove -Wno-deprecated compiler's flag

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12140 )

Change subject: [c++] remove -Wno-deprecated compiler's flag
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12140/3/src/kudu/client/schema.h
File src/kudu/client/schema.h:

http://gerrit.cloudera.org:8080/#/c/12140/3/src/kudu/client/schema.h@254
PS3, Line 254:   (defined(COMPILER_GCC) && (__GNUC__ * 10000 + __GNUC_MINOR__ * 100) >= 40600)
> I see we use COMPILER_GCC elsewhere in the codebase, but I don't think it's
Good catch -- I didn't verify that.  Using __GNUC__ should be more than enough then.



-- 
To view, visit http://gerrit.cloudera.org:8080/12140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I513bd49642755dbcb7ed405391fb13096ee49759
Gerrit-Change-Number: 12140
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 04 Jan 2019 21:53:31 +0000
Gerrit-HasComments: Yes

[kudu-CR] [c++] remove -Wno-deprecated compiler's flag

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12140

to look at the new patch set (#3).

Change subject: [c++] remove -Wno-deprecated compiler's flag
......................................................................

[c++] remove -Wno-deprecated compiler's flag

Removed -Wno-deprecated compiler's flag, replaced some of the
deprecated Kudu API calls with their contemporary counterparts and
added 'pragma GCC diagnostic' blocks elsewhere.

The motivation for this change was seeing too many warnings
while building the python Kudu client.

Change-Id: I513bd49642755dbcb7ed405391fb13096ee49759
---
M CMakeLists.txt
M src/kudu/benchmarks/tpch/rpc_line_item_dao.cc
M src/kudu/client/client-test-util.cc
M src/kudu/client/client-test.cc
M src/kudu/client/scan_token-internal.cc
M src/kudu/client/scan_token-test.cc
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/integration-tests/all_types-itest.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/integration-tests/cluster_verifier.cc
M src/kudu/integration-tests/create-table-stress-test.cc
M src/kudu/integration-tests/delete_table-itest.cc
M src/kudu/integration-tests/flex_partitioning-itest.cc
M src/kudu/integration-tests/full_stack-insert-scan-test.cc
M src/kudu/integration-tests/fuzz-itest.cc
M src/kudu/integration-tests/heavy-update-compaction-itest.cc
M src/kudu/integration-tests/linked_list-test-util.h
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/test_workload.cc
M src/kudu/integration-tests/update_scan_delta_compact-test.cc
M src/kudu/tools/ksck_remote-test.cc
22 files changed, 216 insertions(+), 146 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/12140/3
-- 
To view, visit http://gerrit.cloudera.org:8080/12140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I513bd49642755dbcb7ed405391fb13096ee49759
Gerrit-Change-Number: 12140
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] [c++] remove -Wno-deprecated compiler's flag

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12140

to look at the new patch set (#2).

Change subject: [c++] remove -Wno-deprecated compiler's flag
......................................................................

[c++] remove -Wno-deprecated compiler's flag

Removed -Wno-deprecated compiler's flag, replaced some of the
deprecated Kudu API calls with their contemporary counterparts and
added 'pragma GCC diagnostic' blocks elsewhere.

The motivation for this change was seeing too many warnings
while building the python Kudu client.

Change-Id: I513bd49642755dbcb7ed405391fb13096ee49759
---
M CMakeLists.txt
M src/kudu/benchmarks/tpch/rpc_line_item_dao.cc
M src/kudu/client/client-test-util.cc
M src/kudu/client/client-test.cc
M src/kudu/client/scan_token-internal.cc
M src/kudu/client/scan_token-test.cc
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/integration-tests/all_types-itest.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/integration-tests/cluster_verifier.cc
M src/kudu/integration-tests/create-table-stress-test.cc
M src/kudu/integration-tests/delete_table-itest.cc
M src/kudu/integration-tests/flex_partitioning-itest.cc
M src/kudu/integration-tests/full_stack-insert-scan-test.cc
M src/kudu/integration-tests/fuzz-itest.cc
M src/kudu/integration-tests/heavy-update-compaction-itest.cc
M src/kudu/integration-tests/linked_list-test-util.h
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/test_workload.cc
M src/kudu/integration-tests/update_scan_delta_compact-test.cc
M src/kudu/tools/ksck_remote-test.cc
22 files changed, 210 insertions(+), 146 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/12140/2
-- 
To view, visit http://gerrit.cloudera.org:8080/12140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I513bd49642755dbcb7ed405391fb13096ee49759
Gerrit-Change-Number: 12140
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] [c++] remove -Wno-deprecated compiler's flag

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12140 )

Change subject: [c++] remove -Wno-deprecated compiler's flag
......................................................................


Patch Set 4:

> Please test the C++ samples build on an el6.6 machine to make sure
 > you get the desired behavior in client/schema.h.

Yep, that I verified:

ve0518:examples$ cmake -G "Unix Makefiles" -DkuduClient_DIR=/tmp/xxx/usr/local/share/kuduClient/cmake -DCMAKE_BUILD_TYPE=debug
-- Configuring done
-- Generating done
-- Build files have been written to: /tmp/xxx/usr/local/share/doc/kuduClient/examples
ve0518:examples$ pwd
/tmp/xxx/usr/local/share/doc/kuduClient/examples
ve0518:examples$ make
Scanning dependencies of target example
[100%] Building CXX object CMakeFiles/example.dir/example.cc.o
Linking CXX executable example
[100%] Built target example
ve0518:examples$


-- 
To view, visit http://gerrit.cloudera.org:8080/12140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I513bd49642755dbcb7ed405391fb13096ee49759
Gerrit-Change-Number: 12140
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Sat, 05 Jan 2019 00:31:07 +0000
Gerrit-HasComments: No

[kudu-CR] [c++] remove -Wno-deprecated compiler's flag

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12140 )

Change subject: [c++] remove -Wno-deprecated compiler's flag
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/12140/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/12140/2//COMMIT_MSG@11
PS2, Line 11: 'pragma GCC diagnostic'
> These don't cause warnings when building with clang do they?
That pragma works both for gcc (version 4.6 and higher) and clang, so no warnings when building with clang.  IIRC, we require at least GCC4.8 to build Kudu from source because of C++11 support, so that should be OK.


http://gerrit.cloudera.org:8080/#/c/12140/2/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:

http://gerrit.cloudera.org:8080/#/c/12140/2/src/kudu/client/client-test.cc@1152
PS2, Line 1152:   // TODO: consider fixing this to support returning the column multiple
> warning: missing username/bug in TODO [google-readability-todo]
I'm going to punt on this.


http://gerrit.cloudera.org:8080/#/c/12140/2/src/kudu/client/schema.h
File src/kudu/client/schema.h:

http://gerrit.cloudera.org:8080/#/c/12140/2/src/kudu/client/schema.h@253
PS2, Line 253: #pragma GCC diagnostic push
> This being client/schema.h, is this pragma recognized by el6's version of g
Added ifdefs to target for the gcc versions that supports push/pop for that diagnostic warning.


http://gerrit.cloudera.org:8080/#/c/12140/2/src/kudu/integration-tests/linked_list-test-util.h
File src/kudu/integration-tests/linked_list-test-util.h:

http://gerrit.cloudera.org:8080/#/c/12140/2/src/kudu/integration-tests/linked_list-test-util.h@470
PS2, Line 470: Status LinkedListTester::CreateLinkedListTable() {
> warning: function 'CreateLinkedListTable' defined in a header file; functio
I'm going to punt on this warning.



-- 
To view, visit http://gerrit.cloudera.org:8080/12140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I513bd49642755dbcb7ed405391fb13096ee49759
Gerrit-Change-Number: 12140
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 04 Jan 2019 02:02:49 +0000
Gerrit-HasComments: Yes

[kudu-CR] [c++] remove -Wno-deprecated compiler's flag

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change.  ( http://gerrit.cloudera.org:8080/12140 )

Change subject: [c++] remove -Wno-deprecated compiler's flag
......................................................................


Removed reviewer Kudu Jenkins with the following votes:

* Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/12140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I513bd49642755dbcb7ed405391fb13096ee49759
Gerrit-Change-Number: 12140
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] [c++] remove -Wno-deprecated compiler's flag

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12140

to look at the new patch set (#4).

Change subject: [c++] remove -Wno-deprecated compiler's flag
......................................................................

[c++] remove -Wno-deprecated compiler's flag

Removed -Wno-deprecated compiler's flag, replaced some of the
deprecated Kudu API calls with their contemporary counterparts and
added 'pragma GCC diagnostic' blocks elsewhere.

The motivation for this change was seeing too many warnings
while building the python Kudu client.

Change-Id: I513bd49642755dbcb7ed405391fb13096ee49759
---
M CMakeLists.txt
M src/kudu/benchmarks/tpch/rpc_line_item_dao.cc
M src/kudu/client/client-test-util.cc
M src/kudu/client/client-test.cc
M src/kudu/client/scan_token-internal.cc
M src/kudu/client/scan_token-test.cc
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/integration-tests/all_types-itest.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/integration-tests/cluster_verifier.cc
M src/kudu/integration-tests/create-table-stress-test.cc
M src/kudu/integration-tests/delete_table-itest.cc
M src/kudu/integration-tests/flex_partitioning-itest.cc
M src/kudu/integration-tests/full_stack-insert-scan-test.cc
M src/kudu/integration-tests/fuzz-itest.cc
M src/kudu/integration-tests/heavy-update-compaction-itest.cc
M src/kudu/integration-tests/linked_list-test-util.h
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/test_workload.cc
M src/kudu/integration-tests/update_scan_delta_compact-test.cc
M src/kudu/tools/ksck_remote-test.cc
22 files changed, 216 insertions(+), 146 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/12140/4
-- 
To view, visit http://gerrit.cloudera.org:8080/12140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I513bd49642755dbcb7ed405391fb13096ee49759
Gerrit-Change-Number: 12140
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] [c++] remove -Wno-deprecated compiler's flag

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12140 )

Change subject: [c++] remove -Wno-deprecated compiler's flag
......................................................................


Patch Set 2: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/12140/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/12140/2//COMMIT_MSG@11
PS2, Line 11: 'pragma GCC diagnostic'
These don't cause warnings when building with clang do they?


http://gerrit.cloudera.org:8080/#/c/12140/2/src/kudu/client/schema.h
File src/kudu/client/schema.h:

http://gerrit.cloudera.org:8080/#/c/12140/2/src/kudu/client/schema.h@253
PS2, Line 253: #pragma GCC diagnostic push
This being client/schema.h, is this pragma recognized by el6's version of gcc?



-- 
To view, visit http://gerrit.cloudera.org:8080/12140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I513bd49642755dbcb7ed405391fb13096ee49759
Gerrit-Change-Number: 12140
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Wed, 02 Jan 2019 18:07:21 +0000
Gerrit-HasComments: Yes