[jira] [Work logged] (LOG4J2-2530) StructuredDataMessage is not logged

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LOG4J2-2530?focusedWorklogId=183750&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-183750 ]

ASF GitHub Bot logged work on LOG4J2-2530:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Jan/19 15:40
            Start Date: 10/Jan/19 15:40
    Worklog Time Spent: 10m 
      Work Description: travisspencer commented on pull request #250: LOG4J2-2530 Generalize check for MapMessage
URL: https://github.com/apache/logging-log4j2/pull/250
 
 
   This fixes LOG4J2-2530 by generalizing the check for `MapMessage` to catch not only `StringMapMessage` objects but also `StructuredMapMessgage` objects, fixing an accidental breaking change introduced in 76aff58919dc5030367ea24c7c8ef42dca3b75cd.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 183750)
            Time Spent: 10m
    Remaining Estimate: 0h

> StructuredDataMessage is not logged
> -----------------------------------
>
>                 Key: LOG4J2-2530
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-2530
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.9.0
>            Reporter: Travis Spencer
>            Priority: Major
>         Attachments: instanceof-fix.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> 2.9 introduced a new type {{StringMessageMap}}. When added in commit 76aff58919dc5030367ea24c7c8ef42dca3b75cd, there were a few checks for {{instanceof}} this new type. Consequently, old code that uses {{StructuredDataMessages}} are processed differently. In some cases, such messages are not logged at all. To fix this, the type checks should be generalized to the root base class – {{MapMessage}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)